Merge pull request #249 from kike-alt/feat/replace-typeorm-synchronize

Feat/replace typeorm synchronize

Author: mftee

backend/docs/migration-workflow.md

@@ -0,0 +1,24 @@
+# Migration Workflow Notes
+
+This document outlines the expected TypeORM migration process for issue #229. The goal is to replace `synchronize: true` with an explicit, predictable migration workflow that can be run via the TypeORM CLI.
+
+## 1. Generate a migration
+
+1. Ensure your entity definitions are stable.
+2. Run `npm run migration:generate -- -n DescribeChange` to produce a timestamped migration file under `src/migrations`.
+3. Review the generated SQL carefully before committing.
+
+## 2. Run migrations
+
+Use `npm run migration:run` to apply every pending migration to the target database. This is the command to execute after a fresh `npm install` or when deploying to a new environment.
+
+## 3. Revert the last migration
+
+If you need to back out the most recent change, run `npm run migration:revert`. This command rolls back the latest migration that was applied.
+
+## 4. Best practices
+
+- Commit each migration file alongside the code changes that require it.
+- Never set `synchronize: true` in production—always use migrations so schema changes are tracked.
+- Tag the database version (optional) to align with releases if you have multiple deploy targets.
+- Keep any SQL manual adjustments documented in this file when automatic generation falls short.

backend/src/common/filters/http-exception.filter.ts

@@ -0,0 +1,81 @@
+import {
+  ArgumentsHost,
+  Catch,
+  ExceptionFilter,
+  HttpException,
+  HttpStatus,
+  Logger,
+} from '@nestjs/common';
+import { Response, Request } from 'express';
+
+@Catch()
+export class HttpExceptionFilter implements ExceptionFilter {
+  private readonly logger = new Logger(HttpExceptionFilter.name);
+
+  constructor(private readonly isProduction = false) {}
+
+  catch(exception: unknown, host: ArgumentsHost) {
+    const ctx = host.switchToHttp();
+    const response = ctx.getResponse<Response>();
+    const request = ctx.getRequest<Request>();
+
+    const isHttp = exception instanceof HttpException;
+    const status = isHttp
+      ? exception.getStatus()
+      : HttpStatus.INTERNAL_SERVER_ERROR;
+
+    const errorResponse = isHttp
+      ? exception.getResponse()
+      : { message: (exception as Error)?.message }; // fallback message
+
+    const { message, error } = this.normalizeResponse(errorResponse, exception);
+
+    const payload = {
+      statusCode: status,
+      message,
+      error,
+      timestamp: new Date().toISOString(),
+      path: request.url,
+    };
+
+    this.logger.error(
+      ${status}   -> ,
+      (exception as Error)?.stack,
+    );
+
+    if (!this.isProduction && exception instanceof Error) {
+      Object.assign(payload, { stack: exception.stack });
+    }
+
+    response.status(status).json(payload);
+  }
+
+  private normalizeResponse(
+    response: string | object | null | undefined,
+    exception: unknown,
+  ) {
+    let message = 'Internal server error';
+    let error = HttpStatus.INTERNAL_SERVER_ERROR.toString();
+
+    if (typeof response === 'string') {
+      message = response;
+    } else if (response && typeof response === 'object') {
+      const body = response as Record<string, any>;
+      if (body.message) {
+        message = Array.isArray(body.message)
+          ? body.message.join(', ')
+          : body.message;
+      } else if (exception instanceof Error && exception.message) {
+        message = exception.message;
+      }
+
+      if (body.error) {
+        error = body.error;
+      }
+    } else if (exception instanceof Error) {
+      message = exception.message;
+    }
+
+    return { message, error };
+  }
+}

backend/src/main.ts

@@ -3,6 +3,7 @@ import { AppModule } from './app.module';
 import { ValidationPipe } from '@nestjs/common';
 import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
 import { ConfigService } from '@nestjs/config';
+import { HttpExceptionFilter } from './common/filters/http-exception.filter';
 
 async function bootstrap() {
   const app = await NestFactory.create(AppModule);
@@ -31,6 +32,12 @@ async function bootstrap() {
     }),
   );
 
+  app.useGlobalFilters(
+    new HttpExceptionFilter(
+      configService.get<string>('NODE_ENV') === 'production',
+    ),
+  );
+
   // Swagger documentation
   const config = new DocumentBuilder()
     .setTitle('SMALDA Authentication API')