Skip to content

Commit 399aab4

Browse files
committed
chore(pipelines): update windows runner
- windows-2019 has been phased out by gh
1 parent 140074f commit 399aab4

4 files changed

Lines changed: 27 additions & 5 deletions

File tree

.bazelrc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ build --android_platforms=//:android_arm64
6464
build:windows --extra_toolchains=@local_config_cc//:cc-toolchain-x64_windows-clang-cl
6565
build:windows --extra_execution_platforms=//bazel/platforms:x64_windows-clang-cl
6666
build:windows --features=static_link_msvcrt
67+
build:windows --copt=/EHsc # Enable C++ exception handling (aka '-fno-exceptions' on Linux)
68+
build:windows --copt=/GS- # Disable stack protection (aka '-fno-stack-protector' on Linux)
69+
# '-funwind-tables' are enabled by default on Windows.
70+
# '-fvisibility=hidden' visibility is handled differently on Windows.
6771
# Required as PATH doubles as the shared library search path on Windows and the
6872
# Java agent functionality depends on system-provided shared libraries.
6973
test:windows --noincompatible_strict_action_env

.github/workflows/prerelease.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
name: linux
1717
- os: macos-14
1818
name: macos
19-
- os: windows-2019
19+
- os: windows-2022
2020
name: windows
2121

2222
steps:
@@ -28,6 +28,12 @@ jobs:
2828
distribution: zulu
2929
java-version: 21
3030

31+
- name: Install Clang on Windows
32+
if: matrix.os == 'windows-2022'
33+
run: |
34+
choco install llvm --version=19.1.0 --force
35+
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
36+
3137
- name: Append build settings to .bazelrc
3238
shell: bash
3339
run: |

.github/workflows/run-all-tests-main.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ jobs:
3636
name: Build & Test
3737
strategy:
3838
matrix:
39-
os: [ macos-14, windows-2019 ]
39+
os: [ macos-14, windows-2022 ]
4040
# Test JDK 8 on Windows and mac only on main.
4141
jdk: [8]
4242
include:
4343
- os: macos-14
4444
arch: "macos-arm64"
4545
bazel_args: "--xcode_version_config=//.github:host_xcodes"
46-
- os: windows-2019
46+
- os: windows-2022
4747
arch: "windows"
4848

4949
steps:
@@ -55,6 +55,12 @@ jobs:
5555
distribution: zulu
5656
java-version: 21
5757

58+
- name: Install Clang on Windows
59+
if: matrix.os == 'windows-2022'
60+
run: |
61+
choco install llvm --version=19.1.0 --force
62+
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
63+
5864
- name: Set Build Buddy config
5965
run: .github/scripts/echoBuildBuddyConfig.sh ${{ secrets.BUILDBUDDY_API_KEY }} >> $GITHUB_ENV
6066
shell: bash

.github/workflows/run-all-tests-pr.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
name: Build & Test
1818
strategy:
1919
matrix:
20-
os: [ubuntu-22.04, windows-2019, macos-14]
20+
os: [ubuntu-22.04, windows-2022, macos-14]
2121
jdk: [21]
2222
include:
2323
- jdk: 21
@@ -32,7 +32,7 @@ jobs:
3232
- os: macos-14
3333
arch: "macos-arm64"
3434
bazel_args: "--xcode_version_config=//.github:host_xcodes"
35-
- os: windows-2019
35+
- os: windows-2022
3636
arch: "windows"
3737

3838
steps:
@@ -48,6 +48,12 @@ jobs:
4848
run: .github/scripts/echoBuildBuddyConfig.sh ${{ secrets.BUILDBUDDY_API_KEY }} >> $GITHUB_ENV
4949
shell: bash
5050

51+
- name: Install Clang on Windows
52+
if: matrix.os == 'windows-2022'
53+
run: |
54+
choco install llvm --version=19.1.0 --force
55+
echo "C:\Program Files\LLVM\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
56+
5157
- name: Build & Test
5258
run: bazelisk test ${{env.BUILD_BUDDY_CONFIG}} --java_runtime_version=remotejdk_${{ matrix.jdk }} ${{ matrix.bazel_args }} ${{ matrix.extra_bazel_args }} --build_tag_filters="-no-${{ matrix.arch }},-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" --test_tag_filters="-no-${{ matrix.arch }},-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" //...
5359

0 commit comments

Comments
 (0)