[4.0.0] `UnsafeImplementationAsMap` false-positive

[boris-petrov]

def groups = [groups: groupIds] as Map

This leads to UnsafeImplementationAsMap (and UnnecessaryCast) warnings on Groovy 5 and CodeNarc 4. I believe that's a false-positive.

Also, I get UnnecessaryCast warnings in a few places where, if I remove the casts, the code doesn't compile (under Groovy 5 - Groovy 4 works fine). The example above might be such a false-positive for that also, unsure if it's the same issue as I have in other code.

P.S. Also, congrats on the release! :)

[chrismair]

Thanks. Yeah, it doesn't surprise me that Groovy 5 brings with it some differences, likely in the AST, and how the rules parse and process that.