Skip to content

Commit 902d268

Browse files
committed
Detach removed node in pop_tail for consistency with remove()
1 parent 8e95bf5 commit 902d268

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

Sprint-2/implement_linked_list/linked_list.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,20 @@ def pop_tail(self): # remove element from end of list
2727
if not self.tail:
2828
return None
2929

30-
value = self.tail.value # 2
31-
new_tail = self.tail.previous # 1
30+
old_tail = self.tail
31+
value = self.tail.value
32+
new_tail = self.tail.previous
3233

3334
if new_tail:
3435
new_tail.next = None
3536
else:
3637
self.head = None
3738

3839
self.tail = new_tail
40+
41+
old_tail.previous = None
42+
old_tail.next = None
43+
3944
return value
4045

4146
# [4, 1, 2] - 1

0 commit comments

Comments
 (0)