Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

IMediaServiceProvider-Image extensions #128

@Drjoachim

Description

@Drjoachim

Currently looks like this:

 public interface IMediaServiceProvider
    {
        MediaType SupportedType { get; }
        Task<IEnumerable<MediaItem>> GetItems(string tenantId);
        Task PersistMediaFile(UserInfo userInfo, string mediaUrl);
        Task PersistTextMessage(UserInfo userInfo, TextMessage message);
    }

=> But since we are aiming to implement video #125 ; shouldnt it be changed to:

 public interface IMediaServiceProvider
    {
        MediaType SupportedType { get; }
        Task<IEnumerable<MediaItem>> GetItems(string tenantId);
        Task PersistImageFile(UserInfo userInfo, string mediaUrl, string contentType);
        Task PersistTextMessage(UserInfo userInfo, TextMessage message);
        Task PersistVideoFile(UserInfo userInfo, string mediaUrl, string contentType);
    }

with contentype containing the Mimetype.

I was working on #67 and was just wondering how to properly solve this and if you approve

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions