Skip to content

Commit 6e9dccd

Browse files
committed
fix(helm): Cogstack-ce fix recursive helm dependencies
1 parent ca8c5c2 commit 6e9dccd

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/kubernetes-charts-build.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,17 +110,19 @@ jobs:
110110
fi
111111
echo "chart_version=$CHART_VERSION" >> "$GITHUB_OUTPUT"
112112
113-
- name: Recursive dependency update (all charts)
113+
- name: Recursive dependency update (all charts, including nested)
114114
working-directory: .
115115
run: |
116116
# Run twice so nested subcharts (like cogstack-jupyterhub -> jupyterhub) are fully updated
117117
for _ in 1 2; do
118-
for chart in deployment/kubernetes/charts/*/; do
119-
if [[ -f "${chart}Chart.yaml" ]] && grep -q "^dependencies:" "${chart}Chart.yaml" 2>/dev/null; then
120-
echo "Updating dependencies for $chart"
121-
helm dependency update "$chart"
118+
# Find every Chart.yaml under deployment/kubernetes/charts and run helm dependency update in its directory
119+
while IFS= read -r chartfile; do
120+
chart_dir="$(dirname "$chartfile")"
121+
if grep -q "^dependencies:" "$chartfile" 2>/dev/null; then
122+
echo "Updating dependencies for $chart_dir"
123+
helm dependency update "$chart_dir"
122124
fi
123-
done
125+
done < <(find deployment/kubernetes/charts -type f -name Chart.yaml)
124126
done
125127
126128
- name: Package Helm Charts

0 commit comments

Comments
 (0)