From 1ff7c070be47ae9c973f488a586853c30a8ef550 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 20:53:45 +0200 Subject: [PATCH 1/6] Remove dynamic url setting in chrome manifest This setting was added to the V3 manifest without being functionally implemented until Chrome version 130. Dynamic urls can only be used with the `chrome.runtime.getURL()` API. If this setting is used without accessing the resource over `chrome.runtime.getURL()`, the extension is now using unaccessible resources. Note: By dropping this setting, it's possible to fingerprint users by checking if the resources provided by the extension can be accessed. Since this behavior would be the case with Chrome versions before 130 anyway, it's not too much of a concern. --- manifest-chrome.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/manifest-chrome.json b/manifest-chrome.json index d2d3785..bf879cd 100644 --- a/manifest-chrome.json +++ b/manifest-chrome.json @@ -30,8 +30,7 @@ "web_accessible_resources": [ { "resources": ["/assets/fontawesome/webfonts/*"], - "matches": ["https://www.youtube.com/*"], - "use_dynamic_url": true + "matches": ["https://www.youtube.com/*"] } ] } From 46040cff1b084a0564075c03b5c87748186f21c8 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 21:12:25 +0200 Subject: [PATCH 2/6] Run "Releases" workflow only on semver tags instead of every tag (*) --- .github/workflows/release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index eddd900..869a7d6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -2,7 +2,8 @@ name: "Release" run-name: "Release ${{ github.ref_name }}" on: push: - tags: "*" + tags: + - "[0-9]+.[0-9]+.[0-9]+" jobs: linting: From 97f587013d318c031a27aa559520a54e090eecb7 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 21:13:39 +0200 Subject: [PATCH 3/6] Add hotfix branches to release-drafter autolabeler --- .github/release-drafter.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml index dab9c81..141b166 100644 --- a/.github/release-drafter.yml +++ b/.github/release-drafter.yml @@ -3,9 +3,11 @@ autolabeler: branch: - "/^fix/" - "/^bugfix/" + - "/^hotfix/" title: - "/^fix/i" - "/^bugfix/i" + - "/^hotfix/i" - label: "enhancement" branch: - "/^feature/" @@ -21,6 +23,7 @@ categories: - "fix" - "bugfix" - "bug" + - "hotfix" exclude-labels: - "skip-changelog" category-template: "### $TITLE" From 9a86f9e9f6a34474a5ce361585056c8b35323e73 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 21:47:16 +0200 Subject: [PATCH 4/6] Do not lint and prettier markdown files --- .eslintignore | 1 + .prettierignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.eslintignore b/.eslintignore index b300eca..d564613 100644 --- a/.eslintignore +++ b/.eslintignore @@ -4,3 +4,4 @@ coverage/ karma.conf.js .eslintrc.js tailwind.config.js +*.md \ No newline at end of file diff --git a/.prettierignore b/.prettierignore index d28e550..1336a74 100644 --- a/.prettierignore +++ b/.prettierignore @@ -3,3 +3,4 @@ dist node_modules assets package-lock.json +*.md From 89f5ccccf30328ef88d91431b444c7f0b7c3b364 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 22:10:49 +0200 Subject: [PATCH 5/6] Add excluded files and types to pre-commit hooks --- .pre-commit-config.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7d95621..c670572 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -15,12 +15,23 @@ repos: exclude_types: - svg - pofile - exclude: "(^LICENSE$)" + - markdown + - json + exclude: | + (?x)^( + LICENSE| + \.eslintignore| + \.eslintrc.js| + \.parcelrc| + \.prettierignore| + )$ - id: mixed-line-ending args: - "--fix=lf" - id: trailing-whitespace exclude_types: - svg + - markdown + - json - id: check-case-conflict - id: detect-private-key From 5d54c75dcb83bcdcc60abfba91ada97266748880 Mon Sep 17 00:00:00 2001 From: Andreas Erdes Date: Tue, 3 Jun 2025 21:30:41 +0200 Subject: [PATCH 6/6] Release 1.1.2 --- CHANGELOG.md | 7 +++++++ manifest-chrome.json | 2 +- manifest-firefox.json | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 483d520..678086a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,13 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +## [1.1.2] + +### Fixed + +Icon resources are not loaded and displayed in Chrome versions 130+ due to +`use_dynamic_urls` being functionally implemented. + ## [1.1.1] ### Added diff --git a/manifest-chrome.json b/manifest-chrome.json index bf879cd..5eeea36 100644 --- a/manifest-chrome.json +++ b/manifest-chrome.json @@ -1,7 +1,7 @@ { "manifest_version": 3, "name": "YT Quick Actions", - "version": "1.1.1", + "version": "1.1.2", "description": "Provide quick access to hidden YouTube actions.", "icons": { "16": "assets/extension-icons/chrome/icon16.png", diff --git a/manifest-firefox.json b/manifest-firefox.json index 853aeb4..d088790 100644 --- a/manifest-firefox.json +++ b/manifest-firefox.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "YT Quick Actions", - "version": "1.1.1", + "version": "1.1.2", "description": "Provide quick access to hidden YouTube actions.", "icons": { "48": "assets/extension-icons/firefox/icon.svg",