Skip to content

QR code HTTP endpoint is unauthenticated and DMs are unrestricted #3

@kurt-r2c

Description

@kurt-r2c

The /qr endpoint is served without any authentication at all.

Furthermore, setup.sh default behavior is to allow DMs from anyone:

sed -i "s|TELEGRAM_ALLOWED_DMS=.*|TELEGRAM_ALLOWED_DMS=*|" .env

You should either need some kind of credential to access the QR code page, or DMs should be restricted to a known allowlist. Accidentally making this internet-facing will make it trivially exploitable.

I understand that this is probably meant to be deployed on a kiosk or as part of a lab, but open-source projects like this with HTTP servers will almost always get put on the public internet by someone, somewhere.

Please help novice users avoid shooting themselves in the foot.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions