Three related test-quality gaps:
- No mocking harness — every network/subprocess path (LLM HTTP, GitHub API, remote fetch, plugin install, work git flows) is untested.
- Tests inherit the real environment —
cli_config_init_default can write a real ~/.config/fledge/config.toml and asserts nothing; doctor tests probe the network. Tests should set FLEDGE_CONFIG_DIR/HOME to a tempdir and stub the network.
src/publish.rs test module is tautological — the only real test is an empty #[ignore] stub, leaving the GitHub publish path with zero coverage.
Filed from a skeptical staff-level review (Medium-severity tier). All Critical/High findings and the correctness/doc Medium findings were fixed in #432–442.
Three related test-quality gaps:
cli_config_init_defaultcan write a real~/.config/fledge/config.tomland asserts nothing; doctor tests probe the network. Tests should setFLEDGE_CONFIG_DIR/HOMEto a tempdir and stub the network.src/publish.rstest module is tautological — the only real test is an empty#[ignore]stub, leaving the GitHub publish path with zero coverage.Filed from a skeptical staff-level review (Medium-severity tier). All Critical/High findings and the correctness/doc Medium findings were fixed in #432–442.