Fix bad propagation of AddrOf

Author: lucic71

cpp2rust/converter/converter.cpp

@@ -3700,6 +3700,7 @@ std::string Converter::ConvertPlaceholder(clang::Expr *expr, clang::Expr *arg,
 
   if (ph_ctx.needs_object_receiver()) {
     Buffer buf(*this);
+    PushExprKind push(*this, ExprKind::RValue);
     ConvertDeref(arg);
     return std::move(buf).str();
   }

tests/unit/out/refcount/vector_addr_of_back.rs

@@ -19,5 +19,10 @@ fn main_0() -> i32 {
         ((*outer.borrow())[(*outer.borrow()).len() - 1].as_pointer()),
     ));
     assert!(((*(*sink.borrow()).upgrade().deref()).len() as u64 == 0_u64));
+    let p: Value<Ptr<Vec<Value<Vec<i32>>>>> = Rc::new(RefCell::new((outer.as_pointer())));
+    (*sink.borrow_mut()) = ((*(*p.borrow()).upgrade().deref())
+        [(*(*p.borrow()).upgrade().deref()).len() - 1]
+        .as_pointer());
+    assert!(((*(*sink.borrow()).upgrade().deref()).len() as u64 == 0_u64));
     return 0;
 }

tests/unit/out/unsafe/vector_addr_of_back.rs

@@ -17,5 +17,8 @@ unsafe fn main_0() -> i32 {
     outer.push(inner.clone());
     let mut sink: *mut Vec<i32> = ((outer).last_mut().unwrap());
     assert!((((*sink.cast_const()).len() as u64) == (0_u64)));
+    let mut p: *mut Vec<Vec<i32>> = (&mut outer as *mut Vec<Vec<i32>>);
+    sink = ((*p).last_mut().unwrap());
+    assert!((((*sink.cast_const()).len() as u64) == (0_u64)));
     return 0;
 }

tests/unit/vector_addr_of_back.cpp

@@ -7,5 +7,10 @@ int main() {
   outer.push_back(inner);
   auto *sink = &outer.back();
   assert(sink->size() == 0);
+
+  auto *p = &outer;
+  sink = &p->back();
+  assert(sink->size() == 0);
+
   return 0;
 }