get rid of check-rules

Author: nunoplopes

CMakeLists.txt

@@ -151,6 +151,10 @@ add_custom_target("check"
                   DEPENDS check-libcc2rs check-unit
                  )
 
+add_custom_target("check-all"
+                  DEPENDS check check-benchmarks
+                 )
+
 set(RULES_IR_DIR "${CMAKE_BINARY_DIR}/rules")
 
 file(GLOB rule_subdirs ${PROJECT_SOURCE_DIR}/rules/*)
@@ -201,14 +205,3 @@ add_custom_command(
 
 add_custom_target("preprocess-rust-rules" ALL
                   DEPENDS ${rust_rules_ir_outputs})
-
-add_custom_target("check-rules"
-                  COMMAND ${CMAKE_COMMAND} -E rm -rf "${RULES_IR_DIR}"
-                  COMMAND ${CMAKE_COMMAND} --build ${CMAKE_BINARY_DIR} --target preprocess-cpp-rules
-                  COMMAND ${CMAKE_COMMAND} --build ${CMAKE_BINARY_DIR} --target preprocess-rust-rules
-                  WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-                 )
-
-add_custom_target("check-all"
-                  DEPENDS check-libcc2rs check-rules check-unit check-benchmarks
-                 )

README.md

@@ -133,9 +133,6 @@ ninja check-benchmarks
 # Check benchmark output without executing binaries
 SKIP_RUN=1 ninja check-benchmarks
 
-# Regenerate and check if the IR for the rules changed
-ninja check-rules
-
 # Regenerate expected output for unit tests after intentional changes
 REPLACE_EXPECTED=1 ninja check-unit
 ```

cpp2rust/cpp2rust.cpp

@@ -103,9 +103,8 @@ static bool HasIRFiles(const fs::path &dir) {
 }
 
 static bool ResolveRulesDir() {
-  std::array<fs::path, 3> candidates = {fs::path("./rules"),
-                                        fs::path("../rules"),
-                                        GetExecutableDir() / "../rules"};
+  std::array<fs::path, 2> candidates = {
+      fs::path("./rules"), GetExecutableDir().parent_path() / "rules"};
 
   for (const auto &dir : candidates) {
     if (fs::exists(dir) && fs::is_directory(dir) && HasIRFiles(dir)) {