From 005e1a0e7a09d0d6853a41a35fe42994bd6adb24 Mon Sep 17 00:00:00 2001
From: "Aaron K. Clark" <cryptojones@owasp.org>
Date: Mon, 25 May 2026 22:31:16 -0500
Subject: [PATCH] =?UTF-8?q?chore(rec-28):=20drop=20DBTraceCodeUnitTest.tes?=
 =?UTF-8?q?tFigureOutAssembly=20println-only=20exploration=20=E2=80=94=20w?=
 =?UTF-8?q?ip=20sweep?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Rec 28 #28-6d+ active-@Ignore sweep, ninth wip-bucket deletion. The
removed method's name self-declares its purpose: figure out, by
running it, what the assembler emits for `call 0x4004`:

    @Test
    @Ignore("wip: Debug/TraceModeling cluster #189")
    public void testFigureOutAssembly() throws AssemblySyntaxException, AssemblySemanticException {
        Assembler asm = Assemblers.getAssembler(b.language);
        System.out.println(
            NumericUtilities.convertBytesToString(asm.assembleLine(b.addr(0x4024), "call 0x4004")));
    }

Zero assertions — just a println of the assembled bytes. Author-declared
exploratory scratchpad, same bucket as the JdiExperimentsTest /
DemoFieldsTest / ToArrayTest deletions. fix-or-delete: delete; issue
#189 retains the cluster record.

The wildcard `import ghidra.app.plugin.assembler.*` becomes unused
with the method gone and is dropped too.

Updates docs/testing/ignore-test-inventory.md:
- wip: 36 → 35
- total properly-categorized: 56 → 55

Closes #189 (testFigureOutAssembly portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../trace/database/listing/DBTraceCodeUnitTest.java      | 9 ---------
 docs/testing/ignore-test-inventory.md                    | 4 ++--
 2 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/listing/DBTraceCodeUnitTest.java b/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/listing/DBTraceCodeUnitTest.java
index aa029b35e0f..ad15be991fd 100644
--- a/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/listing/DBTraceCodeUnitTest.java
+++ b/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/listing/DBTraceCodeUnitTest.java
@@ -24,7 +24,6 @@
 import org.junit.*;
 
 import db.*;
-import ghidra.app.plugin.assembler.*;
 import ghidra.docking.settings.Settings;
 import ghidra.program.model.address.*;
 import ghidra.program.model.data.*;
@@ -848,14 +847,6 @@ public void testGetBytes() throws Exception {
 		assertEquals(new BigInteger("-115", 16), lil.getBigInteger(0, 2, true));
 	}
 
-	@Test
-	@Ignore("wip: Debug/TraceModeling cluster #189")
-	public void testFigureOutAssembly() throws AssemblySyntaxException, AssemblySemanticException {
-		Assembler asm = Assemblers.getAssembler(b.language);
-		System.out.println(
-			NumericUtilities.convertBytesToString(asm.assembleLine(b.addr(0x4024), "call 0x4004")));
-	}
-
 	@Test
 	public void testDataValueGetters()
 			throws TraceOverlappedRegionException, CodeUnitInsertionException {
diff --git a/docs/testing/ignore-test-inventory.md b/docs/testing/ignore-test-inventory.md
index a89a798ecd9..a5b449307fb 100644
--- a/docs/testing/ignore-test-inventory.md
+++ b/docs/testing/ignore-test-inventory.md
@@ -23,11 +23,11 @@ Live count from `grep -rn '@Ignore("' Ghidra --include='*.java' | grep -v Repeat
 
 | Category | Count |
 |---|---|
-| `wip` | 36 |
+| `wip` | 35 |
 | `blocked-on` | 19 |
 | `manual-tool` | 1 |
 | `flaky` | 0 |
-| **Total properly-categorized** | **56** |
+| **Total properly-categorized** | **55** |
 
 The `manual-tool` count dropped from 10 → 8 and `flaky` from 3 → 0 in [PR #28-6a](#sequencing): five method-level `@Ignore` lines were removed because their enclosing classes are already `@Ignore`'d at class level (two in `JdiExperimentsTest`/`ProjectExperimentsTest`, three in `JavaMethodsTest`). The method annotations were dead — the class-level annotation skipped them first. Issue references (#178, #190, #193) remain valid; if the class-level ignores are ever lifted, those issues can be re-attached at the method level.