From 36df8fbbbc50b0b95a243a3b8c4e96a749084b03 Mon Sep 17 00:00:00 2001
From: "Aaron K. Clark" <cryptojones@owasp.org>
Date: Mon, 25 May 2026 22:32:48 -0500
Subject: [PATCH] =?UTF-8?q?chore(rec-28):=20drop=20DBTraceProgramViewListi?=
 =?UTF-8?q?ngTest.testGetUndefinedRanges=20TODO-throw=20stub=20=E2=80=94?=
 =?UTF-8?q?=20wip=20sweep?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Rec 28 #28-6d+ active-@Ignore sweep, tenth wip-bucket deletion. The
removed method's body interleaves real setup with a `TODO()` throw,
which short-circuits before reaching the assertion:

    @Test
    @Ignore("wip: Debug/TraceModeling cluster #189")
    public void testGetUndefinedRanges() throws ... {
        try (Transaction tx = b.startTransaction()) {
            b.addData(0, b.addr(0x4000), Undefined4DataType.dataType, b.buf(1, 2, 3, 4));
            b.addInstruction(0, b.addr(0x4005), b.host, b.buf(0xf4, 0));
        }

        TODO(); // Should I expect OTHER ranges in the undefined set?
        assertEquals(b.set(b.range(0, 0x3fff), b.range(0x4004), b.range(0x4007, -1)),
            listing.getUndefinedRanges(...));
    }

`TODO()` throws UnsupportedOperationException, so the assertEquals
below it was dead — the author's question "Should I expect OTHER
ranges in the undefined set?" was never resolved into a real expected
value. The hardcoded expected set is a guess. fix-or-delete: delete;
issue #189 retains the open-question record.

The static `TODO` import was the file's only consumer of
`ghidra.lifecycle.Unfinished.TODO` and is dropped too.

Updates docs/testing/ignore-test-inventory.md:
- wip: 35 → 34
- total properly-categorized: 55 → 54

Closes #189 (testGetUndefinedRanges portion).

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../program/DBTraceProgramViewListingTest.java   | 16 ----------------
 docs/testing/ignore-test-inventory.md            |  4 ++--
 2 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/program/DBTraceProgramViewListingTest.java b/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/program/DBTraceProgramViewListingTest.java
index 2f3a61cddb6..f5f387bd504 100644
--- a/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/program/DBTraceProgramViewListingTest.java
+++ b/Ghidra/Debug/Framework-TraceModeling/src/test/java/ghidra/trace/database/program/DBTraceProgramViewListingTest.java
@@ -15,7 +15,6 @@
  */
 package ghidra.trace.database.program;
 
-import static ghidra.lifecycle.Unfinished.TODO;
 import static org.junit.Assert.*;
 
 import java.io.IOException;
@@ -841,21 +840,6 @@ public void testGetFirstUndefinedData() throws InsufficientBytesException,
 		assertEquals(b.addr(0x4007), cu.getAddress());
 	}
 
-	@Test
-	@Ignore("wip: Debug/TraceModeling cluster #189")
-	public void testGetUndefinedRanges() throws InsufficientBytesException,
-			UnknownInstructionException, CodeUnitInsertionException, CancelledException {
-		try (Transaction tx = b.startTransaction()) {
-			b.addData(0, b.addr(0x4000), Undefined4DataType.dataType, b.buf(1, 2, 3, 4));
-			b.addInstruction(0, b.addr(0x4005), b.host, b.buf(0xf4, 0));
-		}
-
-		TODO(); // Should I expect OTHER ranges in the undefined set?
-		assertEquals(b.set(b.range(0, 0x3fff), b.range(0x4004), b.range(0x4007, -1)),
-			listing.getUndefinedRanges(
-				view.getAddressFactory().getAddressSet(), false, TaskMonitor.DUMMY));
-	}
-
 	@Test
 	public void testGetDefinedCodeUnitAfter() throws InsufficientBytesException,
 			UnknownInstructionException, CodeUnitInsertionException {
diff --git a/docs/testing/ignore-test-inventory.md b/docs/testing/ignore-test-inventory.md
index a5b449307fb..78131964532 100644
--- a/docs/testing/ignore-test-inventory.md
+++ b/docs/testing/ignore-test-inventory.md
@@ -23,11 +23,11 @@ Live count from `grep -rn '@Ignore("' Ghidra --include='*.java' | grep -v Repeat
 
 | Category | Count |
 |---|---|
-| `wip` | 35 |
+| `wip` | 34 |
 | `blocked-on` | 19 |
 | `manual-tool` | 1 |
 | `flaky` | 0 |
-| **Total properly-categorized** | **55** |
+| **Total properly-categorized** | **54** |
 
 The `manual-tool` count dropped from 10 → 8 and `flaky` from 3 → 0 in [PR #28-6a](#sequencing): five method-level `@Ignore` lines were removed because their enclosing classes are already `@Ignore`'d at class level (two in `JdiExperimentsTest`/`ProjectExperimentsTest`, three in `JavaMethodsTest`). The method annotations were dead — the class-level annotation skipped them first. Issue references (#178, #190, #193) remain valid; if the class-level ignores are ever lifted, those issues can be re-attached at the method level.