Skip to content

Commit f577c19

Browse files
CryptoJonesAaron K. Clarkclaude
authored
docs(_bulk-helpers): customer/bulk now uses the factory — drop stale "predates" callout (#250)
The header JSDoc on \`_bulk-helpers.js\` said: "Customer's bulkCreate predates this helper and has the same shape baked in; we don't migrate it here to keep the diff focused on the new endpoints (P3-H), but a follow-up should consolidate them." That follow-up landed; \`customercontroller.js\` now exports \`bulkCreate = makeBulkCreate({ ... })\` like every other bulk-direct endpoint, and Customer is among the 6 entities the factory serves. The "5 near-identical controllers it replaces" line was also off by one for the same reason. Update both lines to match reality: 6 entities use the factory, Customer was migrated in a follow-up after the original P3-H rollout. Co-authored-by: Aaron K. Clark <akclark@thenetwerk.net> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7ca236f commit f577c19

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

app/controllers/_bulk-helpers.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44

55
/**
66
* Shared factory for bulk-create controllers on entities that scope
7-
* directly to a single company via a *CompId column. Customer's
8-
* bulkCreate predates this helper and has the same shape baked in;
9-
* we don't migrate it here to keep the diff focused on the new
10-
* endpoints (P3-H), but a follow-up should consolidate them.
7+
* directly to a single company via a *CompId column.
118
*
12-
* What this factory replaces: 5 near-identical controllers
13-
* (worker/billingtype/inventoryitem/inventorytransaction/
9+
* What this factory replaces: 6 near-identical controllers
10+
* (customer/worker/billingtype/inventoryitem/inventorytransaction/
1411
* purchaseordervendor) each repeating the same auth-scope-loop-
15-
* transaction-bulkCreate-handle-error scaffold.
12+
* transaction-bulkCreate-handle-error scaffold. Customer was the
13+
* original hand-rolled implementation; the factory replaced 5
14+
* later-added clones in P3-H and Customer was migrated to use the
15+
* factory in a follow-up.
1616
*
1717
* What varies between entities — passed as config:
1818
* - Model the sequelize model (db.Worker etc.)

0 commit comments

Comments
 (0)