Description
Currently when looking at ERS, the name of the application is the name of the logger. This should be simplified.
Potential impact radius
Small/Isolated
Reason for change
Make it as clear for the end user what the application that throws the error is
Suggested implementations
Change the call of the constructor and modifying the constructor of and passing the relevant variables to the ERSKafkaPublisher
The challenge here will be to publish the correct application name. As we have a standard toolkit, the simplest way would be if everyone adopted it, and we could establish standard practices. However, as this could take a very long time, if we expand the definition of get_daq_logger to include an optional application_name field, this would be a good intermediary solution. If you include this as an optional, if it is None, it would use the logger name as the application name. If it passed an application name, you could hand this off to the handler, and it would work.
Testing suggestions
Run the same manual tests as defined in #660 and validate that the name has changed from drunc.process_manager.SSH_SHELL_process_manager to process_manager.
Anything else?
No response
Description
Currently when looking at ERS, the name of the application is the name of the logger. This should be simplified.
Potential impact radius
Small/Isolated
Reason for change
Make it as clear for the end user what the application that throws the error is
Suggested implementations
Change the call of the constructor and modifying the constructor of and passing the relevant variables to the ERSKafkaPublisher
The challenge here will be to publish the correct application name. As we have a standard toolkit, the simplest way would be if everyone adopted it, and we could establish standard practices. However, as this could take a very long time, if we expand the definition of
get_daq_loggerto include an optionalapplication_namefield, this would be a good intermediary solution. If you include this as an optional, if it isNone, it would use the logger name as the application name. If it passed an application name, you could hand this off to the handler, and it would work.Testing suggestions
Run the same manual tests as defined in #660 and validate that the name has changed from
drunc.process_manager.SSH_SHELL_process_managertoprocess_manager.Anything else?
No response