Unoptimized `TriggerActivityData` Data Member Order

[aeoranday]

trgdataformats/include/trgdataformats/TriggerActivityData.hpp

Lines 44 to 56 in be9d99a

	version_t version = s_trigger_activity_version; // NOLINT(build/unsigned)
	timestamp_t time_start = INVALID_TIMESTAMP;
	timestamp_t time_end = INVALID_TIMESTAMP;
	timestamp_t time_peak = INVALID_TIMESTAMP;
	timestamp_t time_activity = INVALID_TIMESTAMP;
	channel_t channel_start = INVALID_CHANNEL; // NOLINT(build/unsigned)
	channel_t channel_end = INVALID_CHANNEL; // NOLINT(build/unsigned)
	channel_t channel_peak = INVALID_CHANNEL; // NOLINT(build/unsigned)
	uint64_t adc_integral = 0; // NOLINT(build/unsigned)
	uint16_t adc_peak = 0; // NOLINT(build/unsigned)
	detid_t detid = INVALID_DETID; // NOLINT(build/unsigned)
	Type type = Type::kUnknown; // NOLINT(build/unsigned)
	Algorithm algorithm = Algorithm::kUnknown; // NOLINT(build/unsigned)

By having the TA data members in this order, 8 B of padding are needed for alignment.

[ArturSztuc]

Assigned to target release v5.x.x. If we're changing the order of these, then we might as well rethink which fields do we need.