Skip to content

[Missing Buff Icon] Non-English clients: reminder does not hide on party/raid when they have the buff (use localized spell name for FindAuraByName) #14

@EricMiukyQin

Description

@EricMiukyQin

Behavior

  • Client: Chinese (zhCN); other non-English locales may be affected.
  • Issue: With "Missing buff icon" enabled and the Druid buff (Mark of the Wild) checked, the missing-buff icon still shows on party/raid frames when those units already have the buff. The icon correctly disappears only on the player frame when the player has the buff.
  • Comparison: With Holy Priest's Power Word: Fortitude under the same settings, the missing-buff icon correctly disappears on all frames when the unit has the buff.

Cause

UnitHasBuff uses AuraUtil.FindAuraByName(spellName, unit, "HELPFUL") first. The spellName comes from the English names in DF.RaidBuffs (e.g. "Mark of the Wild"). On non-English clients, aura names on units are localized (e.g. "野性印记" in zhCN), so the string does not match and the buff is not found, and the missing-buff icon never hides.

In-game check (apply Mark of the Wild to party1 first):

  • English name:
    /run print(AuraUtil.FindAuraByName("Mark of the Wild","party1","HELPFUL") and "found" or "not found")
    not found
  • Localized name:
    /run local n=C_Spell.GetSpellInfo(1126).name print(AuraUtil.FindAuraByName(n,"party1","HELPFUL") and "found" or "not found")
    found

Suggested fix

In Frames/Icons.lua, inside UpdateMissingBuffIcon, use the localized spell name for the lookup (e.g. via C_Spell.GetSpellInfo(spellID).name) when calling `Unit

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions