fix(thing_helper): Patch borken sql varible & typing

Author: TylerAdamMartinez

api/thing.py

@@ -297,7 +297,6 @@ def get_springs(
     order: str = None,
     filter_params: Annotated[list[str] | None, Query(alias="filter")] = None,
     query: str = None,
-    name_contains: Optional[str] = None,
 ) -> CustomPage[SpringResponse]:
     """
     Retrieve all springs from the database.
@@ -311,7 +310,6 @@ def get_springs(
         sort,
         thing_type=thing_type,
         filters=filter_params,
-        name_contains=name_contains,
     )
 
 

services/thing_helper.py

@@ -16,7 +16,7 @@
 import logging
 import time
 from datetime import datetime
-from typing import Optional, Sequence
+from typing import Any, Optional, Sequence
 from zoneinfo import ZoneInfo
 
 from fastapi import HTTPException, Request
@@ -125,7 +125,8 @@ def get_db_things(
     name: Optional[str] = None,
     include_contacts: bool = False,
     filters: Optional[list[str]] = None,
-) -> list:
+) -> CustomPage[Any]:
+    sql = select(Thing)
 
     # Querying logic
     #
@@ -187,9 +188,6 @@ def get_db_things(
                     ThingContactAssociation.contact
                 )
             )
-    else:
-        # No search query → return base query (no filtering)
-        sql = select(Thing)
 
     if thing_type:
         sql = sql.where(Thing.thing_type == thing_type)