Skip to content

Add lexicon entries for non-well site types (D, L, S, R, O, OT) #447

@kbighorse

Description

@kbighorse

Summary

During the chemistry orphan investigation (related to #438), we identified that 1,586 downstream chemistry records cannot transfer because their parent locations have site types that don't exist in the thing_type lexicon.

Missing Site Types

SiteType Code Suggested thing_type Locations Downstream Records
D drain 16 452
L lake 10 576
S seep 10 20
R reservoir 9 18
O other 5 183
OT other 3 337
Total 53 1,586

Current State

The existing thing_type lexicon values are:

  • water well
  • spring
  • perennial stream
  • ephemeral stream
  • meteorological station

Tasks

  • Add new thing_type lexicon entries:

    • drain
    • lake
    • seep
    • reservoir
    • other (for O and OT site types)
  • Add transfer functions in transfers/thing_transfer.py for each new site type (similar to existing transfer_springs, transfer_perennial_stream, etc.)

  • Wire up new transfer functions in transfers/transfer.py

  • Re-run chemistry transfers to verify 1,586 records are recovered

Related

Impact

After this is complete, the only remaining chemistry orphans will be 424 records (13 locations) that have no source Location record in the legacy database.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions