Skip to content

Commit 35716b9

Browse files
committed
Renamed switch_to_panel to set_current_panel
1 parent 12f8180 commit 35716b9

3 files changed

Lines changed: 23 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Changes:
66

77
* Remote API:
88
* Added dict-like interface (e.g. `proxy['obj123']`)
9+
* Renamed `switch_to_panel` method to `set_current_panel` (compatibility with DataLab 0.9)
10+
* Added `get_current_panel` method
911

1012
## Version 0.3.0 ##
1113

cdlclient/baseproxy.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,15 @@ def raise_window(self) -> None:
9898
"""Raise DataLab window"""
9999

100100
@abc.abstractmethod
101-
def switch_to_panel(self, panel: str) -> None:
101+
def get_current_panel(self) -> str:
102+
"""Return current panel name.
103+
104+
Returns:
105+
str: Panel name (valid values: "signal", "image", "macro"))
106+
"""
107+
108+
@abc.abstractmethod
109+
def set_current_panel(self, panel: str) -> None:
102110
"""Switch to panel.
103111
104112
Args:
@@ -428,13 +436,21 @@ def raise_window(self) -> None:
428436
"""Raise DataLab window"""
429437
self._cdl.raise_window()
430438

431-
def switch_to_panel(self, panel: str) -> None:
439+
def get_current_panel(self) -> str:
440+
"""Return current panel name.
441+
442+
Returns:
443+
str: Panel name (valid values: "signal", "image", "macro"))
444+
"""
445+
return self._cdl.get_current_panel()
446+
447+
def set_current_panel(self, panel: str) -> None:
432448
"""Switch to panel.
433449
434450
Args:
435451
panel (str): Panel name (valid values: "signal", "image", "macro"))
436452
"""
437-
self._cdl.switch_to_panel(panel)
453+
self._cdl.set_current_panel(panel)
438454

439455
def reset_all(self) -> None:
440456
"""Reset all application data"""

cdlclient/tests/remoteclient_unit.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ def multiple_commands(remote: SimpleRemoteProxy):
6565
remote.reset_all()
6666
remote.open_h5_files([fname], True, False)
6767
remote.import_h5_file(fname, True)
68-
remote.switch_to_panel("signal")
68+
remote.set_current_panel("signal")
69+
assert remote.get_current_panel() == "signal"
6970
remote.calc("log10")
7071

7172
remote.calc("fft")

0 commit comments

Comments
 (0)