refactor: use hard copy for user's full name instead of composite attribute

Author: SlimDeluxe

database/migrations/0001_01_01_000000_create_users_table.php

@@ -13,6 +13,7 @@ public function up(): void
     {
         Schema::create('users', function (Blueprint $table) {
             $table->id();
+            $table->string('name')->nullable();
             $table->string('first_name')->nullable();
             $table->string('last_name')->nullable();
             $table->string('email')->unique();

src/Filament/Resources/UserResource.php

@@ -87,10 +87,9 @@ public static function table(Table $table): Table
                 ->searchable()
                 ->sortable()
                 ->toggleable(),
-            Tables\Columns\TextColumn::make('full_name')
-                ->searchable(query: function (Builder $query, string $search): Builder {
-                    return $query->whereRaw(User::getCompositeDefinition('full_name').' LIKE ?', ["%$search%"]);
-                })
+            Tables\Columns\TextColumn::make('name')
+                ->label('Full name')
+                ->searchable()
                 ->sortable()
                 ->toggleable(),
         ];
@@ -148,7 +147,12 @@ public static function table(Table $table): Table
 
         $filters[] = Tables\Filters\QueryBuilder::make()
             ->constraints([
-                TextConstraint::make('first_name'),
+                TextConstraint::make('first_name')
+                    ->label('First name'),
+                TextConstraint::make('last_name')
+                    ->label('Last name'),
+                TextConstraint::make('name')
+                    ->label('Full name'),
             ]);
 
         return $table
@@ -200,7 +204,7 @@ public static function infolist(Infolist $infolist): Infolist
                         ->circular(),
                     Group::make()
                         ->schema([
-                            TextEntry::make('full_name')
+                            TextEntry::make('name')
                                 ->label('Full name'),
                             TextEntry::make('email')
                                 ->icon(config('eclipse.email_verification') ? fn (User $user) => $user->email_verified_at ? 'heroicon-s-check-circle' : 'heroicon-s-x-circle' : null)

src/Foundation/Model/HasCompositeAttributes.php

@@ -3,7 +3,6 @@
 namespace Eclipse\Core\Models;
 
 use Eclipse\Core\Database\Factories\UserFactory;
-use Eclipse\Core\Foundation\Model\HasCompositeAttributes;
 use Filament\Models\Contracts\FilamentUser;
 use Filament\Models\Contracts\HasAvatar;
 use Filament\Models\Contracts\HasName;
@@ -14,13 +13,13 @@
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
 use Illuminate\Support\Collection;
-use Illuminate\Support\Facades\DB;
 use Spatie\MediaLibrary\HasMedia;
 use Spatie\MediaLibrary\InteractsWithMedia;
 use Spatie\Permission\Traits\HasRoles;
 
 /**
  * @property int $id
+ * @property-read string|null $name
  * @property string|null $first_name
  * @property string|null $last_name
  * @property string $email
@@ -29,11 +28,10 @@
  * @property string|null $remember_token
  * @property string|null $created_at
  * @property string|null $updated_at
- * @property-read string $full_name User's full name
  */
 class User extends Authenticatable implements FilamentUser, HasAvatar, HasMedia, HasName, HasTenants
 {
-    use HasCompositeAttributes, HasFactory, HasRoles, InteractsWithMedia, Notifiable;
+    use HasFactory, HasRoles, InteractsWithMedia, Notifiable;
 
     protected $table = 'users';
 
@@ -92,20 +90,6 @@ public function getFilamentName(): string
         return "$this->first_name $this->last_name";
     }
 
-    protected static function defineCompositeAttributes(): array
-    {
-        switch (DB::getDriverName()) {
-            case 'sqlite':
-                return [
-                    'full_name' => "users.first_name || ' ' || users.last_name",
-                ];
-            default:
-                return [
-                    'full_name' => "TRIM(CONCAT(IFNULL(users.first_name, ''), ' ', IFNULL(users.last_name, '')))",
-                ];
-        }
-    }
-
     public function canAccessTenant(Model $tenant): bool
     {
         return $this->sites()->whereKey($tenant)->exists();
@@ -125,4 +109,11 @@ protected static function newFactory()
     {
         return UserFactory::new();
     }
+
+    protected static function booted()
+    {
+        static::saving(function (self $user) {
+            $user->name = trim("$user->first_name $user->last_name");
+        });
+    }
 }