From d823811a9fb417687edb62c56e3121a96ca34f07 Mon Sep 17 00:00:00 2001 From: Kilian Trunk Date: Fri, 10 Oct 2025 12:15:18 +0200 Subject: [PATCH 1/5] ci: remove filament support --- .github/workflows/test-runner.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-runner.yml b/.github/workflows/test-runner.yml index 75d06db..7c73a73 100644 --- a/.github/workflows/test-runner.yml +++ b/.github/workflows/test-runner.yml @@ -65,7 +65,7 @@ jobs: - name: Install dependencies run: | - composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" "filament/support:^3.3" --no-interaction --no-update + composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update composer update --${{ matrix.dependency-version }} --prefer-dist --no-progress --no-interaction - name: Run test suite From 38473c50af99567f241f0651b3e7d5f0e5d68e7f Mon Sep 17 00:00:00 2001 From: Kilian Trunk Date: Fri, 10 Oct 2025 12:16:35 +0200 Subject: [PATCH 2/5] chore: random change to trigger tests --- tests/TestCase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TestCase.php b/tests/TestCase.php index a6a0767..8786f5d 100644 --- a/tests/TestCase.php +++ b/tests/TestCase.php @@ -77,7 +77,7 @@ public function ignorePackageDiscoveriesFrom() } /** - * Create permissions for all resources + * Create permissions for all resources. */ protected function createPermissions(): self { From 7eca8d4da7aa1470ecc3f4277ebec6a9510914e7 Mon Sep 17 00:00:00 2001 From: Kilian Trunk Date: Fri, 10 Oct 2025 12:16:45 +0200 Subject: [PATCH 3/5] Revert "chore: random change to trigger tests" This reverts commit 38473c50af99567f241f0651b3e7d5f0e5d68e7f. --- tests/TestCase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TestCase.php b/tests/TestCase.php index 8786f5d..a6a0767 100644 --- a/tests/TestCase.php +++ b/tests/TestCase.php @@ -77,7 +77,7 @@ public function ignorePackageDiscoveriesFrom() } /** - * Create permissions for all resources. + * Create permissions for all resources */ protected function createPermissions(): self { From 1c47e2c526ee21ce2761ceb203bc646b09e053c8 Mon Sep 17 00:00:00 2001 From: Kilian Trunk Date: Fri, 10 Oct 2025 12:22:09 +0200 Subject: [PATCH 4/5] chore: fix country tests this fixes e.g. Failed asserting that two strings are equal. -'041' +'41' --- src/Models/Country.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/Models/Country.php b/src/Models/Country.php index 4803e42..ae39281 100644 --- a/src/Models/Country.php +++ b/src/Models/Country.php @@ -90,4 +90,17 @@ protected static function newFactory(): CountryFactory { return CountryFactory::new(); } + + /** + * Ensure numeric code is always stored as a 3-character, zero-padded string. + */ + public function setNumCodeAttribute($value): void + { + if ($value === null || $value === '') { + $this->attributes['num_code'] = null; + return; + } + + $this->attributes['num_code'] = str_pad((string) $value, 3, '0', STR_PAD_LEFT); + } } From f5da0ed4c02f4b653da51a54ab4907ae46bcfad6 Mon Sep 17 00:00:00 2001 From: Kilian Trunk Date: Fri, 10 Oct 2025 12:23:32 +0200 Subject: [PATCH 5/5] chore: format --- src/Models/Country.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Models/Country.php b/src/Models/Country.php index ae39281..1203377 100644 --- a/src/Models/Country.php +++ b/src/Models/Country.php @@ -98,6 +98,7 @@ public function setNumCodeAttribute($value): void { if ($value === null || $value === '') { $this->attributes['num_code'] = null; + return; }