fix(poly create base, component): exit with fail code if brick already exists (#431)

* fix(poly create base, component): exit with fail code if brick already exists

* bump the CLI to 1.43.0

* bump the Poetry plugin to 1.49.0

Author: DavidVujic

bases/polylith/cli/create.py

@@ -10,13 +10,22 @@
 app = Typer()
 
 
+def _try_create(name: str, description: str, fn):
+    try:
+        create(name, description, fn)
+    except ValueError as e:
+        print(f"Did not create: {e}")
+
+        raise Exit(code=1)
+
+
 @app.command("base")
 def base_command(
     name: Annotated[str, Option(help="Name of the base.")],
     description: Annotated[str, Option(help="Description of the base.")] = "",
 ):
     """Creates a Polylith base."""
-    create(name, description, base.create_base)
+    _try_create(name, description, base.create_base)
 
 
 @app.command("component")
@@ -25,7 +34,7 @@ def component_command(
     description: Annotated[str, Option(help="Description of the component.")] = "",
 ):
     """Creates a Polylith component."""
-    create(name, description, component.create_component)
+    _try_create(name, description, component.create_component)
 
 
 def _create_project(root: Path, options: dict):

components/polylith/bricks/brick.py

@@ -1,14 +1,32 @@
 from pathlib import Path
 
-from polylith import configuration
+from polylith import configuration, info
 from polylith.dirs import create_dir
 from polylith.files import create_file
 from polylith.interface import create_interface
 from polylith.readme import create_brick_readme
 
 
+def validate(root: Path, namespace: str, name: str) -> None:
+    bases = info.get_bases(root, namespace)
+    components = info.get_components(root, namespace)
+
+    if name in bases:
+        message = f"{name} already exists in bases."
+        raise ValueError(message)
+
+    if name in components:
+        message = f"{name} already exists in components."
+        raise ValueError(message)
+
+
 def create_brick(root: Path, options: dict) -> None:
     modulename = options["modulename"]
+    package = options["package"]
+    namespace = options["namespace"]
+
+    validate(root, namespace, package)
+
     path_kwargs = {
         k: v for k, v in options.items() if k in {"brick", "namespace", "package"}
     }

components/polylith/poetry/commands/create_base.py

@@ -1,7 +1,7 @@
 from cleo.helpers import option
 from poetry.console.commands.command import Command
 from polylith.bricks import base
-from polylith.commands.create import create
+from polylith.poetry.commands.create_brick import try_create
 
 
 class CreateBaseCommand(Command):
@@ -20,9 +20,4 @@ class CreateBaseCommand(Command):
     ]
 
     def handle(self) -> int:
-        name = self.option("name")
-        description = self.option("description")
-
-        create(name, description, base.create_base)
-
-        return 0
+        return try_create(self, base.create_base)

components/polylith/poetry/commands/create_brick.py

@@ -0,0 +1,16 @@
+from poetry.console.commands.command import Command
+from polylith.commands.create import create
+
+
+def try_create(command: Command, fn) -> int:
+    name = command.option("name")
+    description = command.option("description")
+
+    try:
+        create(name, description, fn)
+    except ValueError as e:
+        command.line_error(f"Did not create: <error>{e}</error>")
+
+        return 1
+
+    return 0

components/polylith/poetry/commands/create_component.py

@@ -1,7 +1,7 @@
 from cleo.helpers import option
 from poetry.console.commands.command import Command
 from polylith.bricks import component
-from polylith.commands.create import create
+from polylith.poetry.commands.create_brick import try_create
 
 
 class CreateComponentCommand(Command):
@@ -20,9 +20,4 @@ class CreateComponentCommand(Command):
     ]
 
     def handle(self) -> int:
-        name = self.option("name")
-        description = self.option("description")
-
-        create(name, description, component.create_component)
-
-        return 0
+        return try_create(self, component.create_component)

projects/poetry_polylith_plugin/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "poetry-polylith-plugin"
-version = "1.48.4"
+version = "1.49.0"
 description = "A Poetry plugin that adds tooling support for the Polylith Architecture"
 authors = ["David Vujic"]
 homepage = "https://davidvujic.github.io/python-polylith-docs/"

projects/polylith_cli/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "polylith-cli"
-version = "1.42.5"
+version = "1.43.0"
 description = "Python tooling support for the Polylith Architecture"
 authors = ['David Vujic']
 homepage = "https://davidvujic.github.io/python-polylith-docs/"