Skip to content

Commit ae7efab

Browse files
authored
Merge pull request #9 from DeclareDesign/cran-patch-rev
Cran patch rev - Version 1.0.8
2 parents dfbb69d + fda8ef1 commit ae7efab

9 files changed

Lines changed: 27 additions & 14 deletions

File tree

CRAN-SUBMISSION

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
Version: 1.0.6
2-
Date: 2024-02-19 20:16:25 UTC
3-
SHA: 3de944cf1406e5330c4a44392b969e6f8fcfde75
1+
Version: 1.0.8
2+
Date: 2024-03-02 18:35:10 UTC
3+
SHA: be95cd907b6e1c1cb42c645a50a1a1bbb7a45486

DESCRIPTION

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: rdss
22
Title: Companion Datasets and Functions for Research Design in the Social Sciences
3-
Version: 1.0.6
3+
Version: 1.0.8
44
Authors@R:
55
c(person("Graeme", "Blair", email = "graeme.blair@gmail.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-9164-2102")),
66
person("Alexander", "Coppock", email = "acoppock@gmail.com", role = c("aut"), comment = c(ORCID = "0000-0002-5733-2386")),
@@ -24,7 +24,8 @@ Suggests:
2424
lme4,
2525
rstanarm,
2626
spdep,
27-
DeclareDesign
27+
DeclareDesign,
28+
curl
2829
Depends:
2930
R (>= 2.10)
3031
Config/testthat/edition: 3

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# rdss 1.0.8
2+
3+
* Documentation updates for CRAN.
4+
15
# rdss 1.0.6
26

37
* Update to new roxygen and R package documentation standards for CRAN.

R/data.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#' @format A data.frame
3030
"foos_etal"
3131

32-
#' Replication data for David Clingingsmith, Asim Ijaz Khwaja, Michael Kremer (2020): Estimating the Impact of The Hajj: Religion and Tolerance in Islam's Global Gathering. The Quarterly Journal of Economics, Volume 124, Issue 3, August 2009, Pages 11331170
32+
#' Replication data for David Clingingsmith, Asim Ijaz Khwaja, Michael Kremer (2020): Estimating the Impact of The Hajj: Religion and Tolerance in Islam's Global Gathering. The Quarterly Journal of Economics, Volume 124, Issue 3, August 2009, Pages 1133-1170
3333
#'
3434
#' @format A data.frame
3535
"clingingsmith_etal"

R/get_replication_file.R

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,19 @@
158158
#' @examples
159159
#'
160160
#' \donttest{
161-
#' diagnosis_2.1 <- get_rdss_file("diagnosis_2.1")
162-
#' diagnosis_2.1
161+
#' # Requires internet access
162+
#' if(curl::has_internet()) {
163+
#' diagnosis_2.1 <- get_rdss_file("diagnosis_2.1")
164+
#' diagnosis_2.1
165+
#' }
163166
#' }
164167
get_rdss_file <- function(name, verbose = TRUE) {
165168
if(!"DeclareDesign" %in% loadedNamespaces()){
166169
stop("Please load DeclareDesign before running this function via library(DeclareDesign).")
167170
}
171+
if(!curl::has_internet()) {
172+
stop("This function requires internet access.")
173+
}
168174
if(substr(name, 1, 9) == "diagnosis") {
169175
return(get_dataframe_by_name(
170176
filename = paste0(name, ".rds"),

cran-comments.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Submission
22

3-
Submission to resolve roxygen issues wrt Kurt email, a small feature change to one function, and resubmitting after a dependency (DIDmultiplegt) was put back on CRAN. We implement it it conditionally on availability now.
3+
Submission to resolve internet connection-required example.
44

55
## Test environments
66

man/clingingsmith_etal.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/get_rdss_file.Rd

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
test_that("process_tracing_estimator works", {
33

44
skip_if_not_installed("CausalQueries")
5-
skip_on_cran()
65

76
library(DeclareDesign)
87
library(CausalQueries)

0 commit comments

Comments
 (0)