|
| 1 | +import { describe, expect, it, vi } from "vitest"; |
| 2 | + |
| 3 | +import { PageCollabRoom } from "./page-collab-room.js"; |
| 4 | + |
| 5 | +function createMockWebSocket(id: string): WebSocket & { sent: Uint8Array[]; closed: boolean } { |
| 6 | + const sent: Uint8Array[] = []; |
| 7 | + const ws = { |
| 8 | + sent, |
| 9 | + closed: false, |
| 10 | + serializeAttachment: vi.fn(), |
| 11 | + deserializeAttachment: vi.fn(() => ({ userId: `user-${id}` })), |
| 12 | + send: vi.fn((data: ArrayBuffer | string) => { |
| 13 | + if (typeof data !== "string") { |
| 14 | + sent.push(new Uint8Array(data)); |
| 15 | + } |
| 16 | + }), |
| 17 | + close: vi.fn(() => { |
| 18 | + (ws as unknown as { closed: boolean }).closed = true; |
| 19 | + }), |
| 20 | + addEventListener: vi.fn(), |
| 21 | + removeEventListener: vi.fn(), |
| 22 | + } as unknown as WebSocket & { sent: Uint8Array[]; closed: boolean }; |
| 23 | + return ws; |
| 24 | +} |
| 25 | + |
| 26 | +function createMockDoState(sockets: WebSocket[]): DurableObjectState { |
| 27 | + const storage = { |
| 28 | + getAlarm: vi.fn(() => Promise.resolve(null)), |
| 29 | + setAlarm: vi.fn(() => Promise.resolve()), |
| 30 | + deleteAlarm: vi.fn(() => Promise.resolve()), |
| 31 | + get: vi.fn(), |
| 32 | + put: vi.fn(), |
| 33 | + delete: vi.fn(), |
| 34 | + deleteAll: vi.fn(), |
| 35 | + list: vi.fn(), |
| 36 | + transaction: vi.fn(), |
| 37 | + }; |
| 38 | + return { |
| 39 | + getWebSockets: vi.fn(() => sockets), |
| 40 | + acceptWebSocket: vi.fn(), |
| 41 | + waitUntil: vi.fn(), |
| 42 | + storage: storage as unknown as DurableObjectStorage, |
| 43 | + id: {} as unknown as DurableObjectId, |
| 44 | + transaction: vi.fn(), |
| 45 | + get: vi.fn(), |
| 46 | + put: vi.fn(), |
| 47 | + delete: vi.fn(), |
| 48 | + deleteAll: vi.fn(), |
| 49 | + list: vi.fn(), |
| 50 | + getAlarm: vi.fn(), |
| 51 | + setAlarm: vi.fn(), |
| 52 | + deleteAlarm: vi.fn(), |
| 53 | + setHibernationWebSocketEventTimeout: vi.fn(), |
| 54 | + getHibernationWebSocketEventTimeout: vi.fn(), |
| 55 | + getWebSocketAutoResponse: vi.fn(), |
| 56 | + setWebSocketAutoResponse: vi.fn(), |
| 57 | + getTags: vi.fn(), |
| 58 | + getStub: vi.fn(), |
| 59 | + requestDelegate: vi.fn(), |
| 60 | + dispose: vi.fn(), |
| 61 | + getHibernatableWebSocketEventTimeout: vi.fn(), |
| 62 | + setHibernatableWebSocketEventTimeout: vi.fn(), |
| 63 | + getHibernationWebSocketEventTimeoutTimestamp: vi.fn(), |
| 64 | + getHibernationWebSocketEventTimeoutMilliseconds: vi.fn(), |
| 65 | + getWebSocketEventTimeout: vi.fn(), |
| 66 | + setWebSocketEventTimeout: vi.fn(), |
| 67 | + } as unknown as DurableObjectState; |
| 68 | +} |
| 69 | + |
| 70 | +describe("PageCollabRoom", () => { |
| 71 | + it("chunks broadcast into batches of at most 10 sockets", async () => { |
| 72 | + const data = new Uint8Array([1, 2, 3]); |
| 73 | + const sockets = Array.from({ length: 25 }, (_, i) => createMockWebSocket(String(i))); |
| 74 | + const state = createMockDoState(sockets); |
| 75 | + const room = new PageCollabRoom(state, { |
| 76 | + COLLAB_INTERNAL_SECRET: "secret", |
| 77 | + WORKER_SELF: { |
| 78 | + fetch: vi.fn(() => |
| 79 | + Promise.resolve( |
| 80 | + new Response(JSON.stringify({ newIndex: 1 }), { status: 200 }), |
| 81 | + ), |
| 82 | + ), |
| 83 | + } as unknown as Fetcher, |
| 84 | + }); |
| 85 | + |
| 86 | + const sender = sockets[0]!; |
| 87 | + await (room as unknown as { broadcast: (except: WebSocket, data: Uint8Array) => Promise<void> }).broadcast(sender, data); |
| 88 | + |
| 89 | + // sender should not receive the message |
| 90 | + expect(sender.sent).toHaveLength(0); |
| 91 | + |
| 92 | + // remaining 24 sockets should each receive exactly one message |
| 93 | + const receivers = sockets.slice(1); |
| 94 | + for (const r of receivers) { |
| 95 | + expect(r.sent).toHaveLength(1); |
| 96 | + expect(r.sent[0]).toEqual(data); |
| 97 | + } |
| 98 | + |
| 99 | + // Verify that getWebSockets was called |
| 100 | + expect(state.getWebSockets).toHaveBeenCalled(); |
| 101 | + }); |
| 102 | + |
| 103 | + it("broadcast does nothing when no other sockets are connected", async () => { |
| 104 | + const data = new Uint8Array([1, 2, 3]); |
| 105 | + const sender = createMockWebSocket("0"); |
| 106 | + const state = createMockDoState([sender]); |
| 107 | + const room = new PageCollabRoom(state, {}); |
| 108 | + |
| 109 | + await (room as unknown as { broadcast: (except: WebSocket, data: Uint8Array) => Promise<void> }).broadcast(sender, data); |
| 110 | + |
| 111 | + expect(sender.sent).toHaveLength(0); |
| 112 | + }); |
| 113 | + |
| 114 | + it("ignores broken peers during broadcast", async () => { |
| 115 | + const data = new Uint8Array([1, 2, 3]); |
| 116 | + const good = createMockWebSocket("good"); |
| 117 | + const bad = createMockWebSocket("bad"); |
| 118 | + bad.send = vi.fn(() => { |
| 119 | + throw new Error("broken"); |
| 120 | + }); |
| 121 | + |
| 122 | + const state = createMockDoState([good, bad]); |
| 123 | + const room = new PageCollabRoom(state, {}); |
| 124 | + |
| 125 | + await (room as unknown as { broadcast: (except: WebSocket, data: Uint8Array) => Promise<void> }).broadcast(good, data); |
| 126 | + |
| 127 | + expect(good.sent).toHaveLength(0); // sender excluded |
| 128 | + expect(bad.sent).toHaveLength(0); // threw, but no crash |
| 129 | + }); |
| 130 | + |
| 131 | + it("alarm closes sockets when verify returns not allowed", async () => { |
| 132 | + const ws1 = createMockWebSocket("1"); |
| 133 | + const ws2 = createMockWebSocket("2"); |
| 134 | + const state = createMockDoState([ws1, ws2]); |
| 135 | + const room = new PageCollabRoom(state, { |
| 136 | + COLLAB_INTERNAL_SECRET: "secret", |
| 137 | + WORKER_SELF: { |
| 138 | + fetch: vi.fn(() => |
| 139 | + Promise.resolve( |
| 140 | + new Response(JSON.stringify({ allowed: false }), { status: 200 }), |
| 141 | + ), |
| 142 | + ), |
| 143 | + } as unknown as Fetcher, |
| 144 | + }); |
| 145 | + |
| 146 | + await room.alarm(); |
| 147 | + |
| 148 | + expect(ws1.closed).toBe(true); |
| 149 | + expect(ws2.closed).toBe(true); |
| 150 | + expect(state.storage.setAlarm).toHaveBeenCalledWith(expect.any(Number)); |
| 151 | + }); |
| 152 | + |
| 153 | + it("alarm closes sockets when verify returns non-ok", async () => { |
| 154 | + const ws1 = createMockWebSocket("1"); |
| 155 | + const state = createMockDoState([ws1]); |
| 156 | + const room = new PageCollabRoom(state, { |
| 157 | + COLLAB_INTERNAL_SECRET: "secret", |
| 158 | + WORKER_SELF: { |
| 159 | + fetch: vi.fn(() => |
| 160 | + Promise.resolve(new Response("Forbidden", { status: 403 })), |
| 161 | + ), |
| 162 | + } as unknown as Fetcher, |
| 163 | + }); |
| 164 | + |
| 165 | + await room.alarm(); |
| 166 | + |
| 167 | + expect(ws1.closed).toBe(true); |
| 168 | + }); |
| 169 | + |
| 170 | + it("webSocketMessage closes socket on 403 from collab-ws-append", async () => { |
| 171 | + const ws1 = createMockWebSocket("1"); |
| 172 | + const state = createMockDoState([ws1]); |
| 173 | + const room = new PageCollabRoom(state, { |
| 174 | + COLLAB_INTERNAL_SECRET: "secret", |
| 175 | + WORKER_SELF: { |
| 176 | + fetch: vi.fn(() => |
| 177 | + Promise.resolve(new Response("Forbidden", { status: 403 })), |
| 178 | + ), |
| 179 | + } as unknown as Fetcher, |
| 180 | + }); |
| 181 | + |
| 182 | + // Encode a minimal client update message |
| 183 | + const { encodeDocSingleUpdateFromClient } = await import("@deepnotes/collab-wire"); |
| 184 | + const msg = encodeDocSingleUpdateFromClient({ |
| 185 | + updateId: 1, |
| 186 | + encryptedUpdate: new Uint8Array([1, 2, 3]), |
| 187 | + }); |
| 188 | + |
| 189 | + await room.webSocketMessage(ws1, msg.buffer.slice(msg.byteOffset, msg.byteOffset + msg.byteLength) as ArrayBuffer); |
| 190 | + |
| 191 | + expect(ws1.closed).toBe(true); |
| 192 | + }); |
| 193 | +}); |
0 commit comments