feat: remove demo

Author: gustavotoyota

docs/restart-plan/README.md

@@ -62,7 +62,7 @@ A criterion is **not met** until the verification command or check passes in CI.
 - [ ] **Spatial polish (Phase 6):** ≥ 80% of `docs/SPATIAL_PARITY_CHECKLIST.md` rows marked done.
 - [ ] **Schema completeness:** Phase 3 Yjs schema includes every field from the Phase 1 diff table.
 - [x] **Backlinks:** SPA displays incoming page backlinks.
-- [x] **Playwright:** E2E smoke test covers demo login → home → page → groups → logout.
+- [x] **Playwright:** E2E smoke test covers login → home → page → groups → logout.
 - [x] **Package split:** `@deepnotes/session` split into `@deepnotes/session-core`, `@deepnotes/groups`, `@deepnotes/pages`, `@deepnotes/billing`, `@deepnotes/realtime`. Session package now has 8 files (down from 57).
 - [x] **Marketing site:** `apps/marketing` has routable pages for `/`, `/pricing`, `/whitepaper`, `/help`, `/privacy-policy`, `/terms-of-service`. Build outputs 20 static HTML files (including 14 help article sub-routes). `pnpm lint`, `pnpm typecheck`, `pnpm build` pass with 0 errors. Dark/light theme toggle, restored legacy assets (logo, whitepaper diagrams, use-case thumbnails), and Shadcn `Switch`/`Input` components integrated.
 - [ ] **Staging:** Hyperdrive + Postgres + Redis + WS proven in staging. Load test: 50 concurrent pages, p95 latency < 200 ms, row rate ≤ 20/page.

docs/restart-plan/appendix-auth-migration-evaluation.md

@@ -28,7 +28,6 @@
 - Authenticator secret and recovery codes encrypted with env keys.
 - `devices.trusted = true` set on login when `rememberDevice` is passed and token is valid.
 - Failed-login rate-limiting (Redis counters, 4-attempt threshold, 15-min TTL) incremented on bad TOTP or bad recovery code.
-- Demo-account rejection (`demo === true` → `403 FORBIDDEN`).
 
 ### What improved
 
@@ -110,7 +109,6 @@ Single HTTP call (`POST /api/users/me/password`):
 | Password change invalidates all sessions | ✅ |
 | Password change rejects wrong old password | ✅ |
 | Password change rejects demo user | ✅ |
-| 2FA enable/finish persists flags | ✅ |
 | 2FA login succeeds with valid TOTP | ✅ |
 | 2FA login rejects missing TOTP | ✅ |
 | 2FA login rejects invalid TOTP | ✅ |

docs/restart-plan/phase-7-account-polish.md

@@ -50,7 +50,7 @@ All non-editor UX is polished and tested.
      - `@deepnotes/billing` — Stripe checkout, portal, webhook processing (`stripe-billing.ts`, `stripe-billing.test.ts`).
      - `@deepnotes/collab` — Page collab updates, collab crypto context, snapshots (`page-collab-updates.ts`, `group-collab-crypto-context.ts`).
      - `@deepnotes/realtime` — Hash ACL, notify-users (`realtime-hash-acl.ts`, `notify-users.ts`).
-     - Keep `@deepnotes/session` for auth, login, refresh, register, 2FA, logout, demo, tokens only.
+     - Keep `@deepnotes/session` for auth, login, refresh, register, 2FA, logout, tokens only.
    - Add ESLint rule: `apps/api-worker` route files may import from ≤ 2 domain packages each.
    - Exit criteria: no extracted package exceeds 25 files; `@deepnotes/session` ≤ 20 files.
 
@@ -80,8 +80,8 @@ A full evaluation of TOTP, password change, and email change migration is in [ap
 
 ## Verification
 
-- E2E smoke test: demo login → home → starting page → groups → logout.
-  - `apps/web/e2e/smoke.spec.ts` covers demo login, home page, page editor load, groups list, and logout.
+- E2E smoke test: login → home → starting page → groups → logout.
+  - `apps/web/e2e/smoke.spec.ts` covers login, home page, page editor load, groups list, and logout.
   - Full flow (register → create group → create page → invite member → member joins → both edit page → logout) requires group/page creation UI which is not yet implemented in the SPA.
 - Playwright config updated to start both `api-worker` and `web` dev servers.
 - Integration test: `scheduled-cleanup.integration.test.ts` verifies soft-deleted pages and groups are purged.
@@ -91,7 +91,7 @@ A full evaluation of TOTP, password change, and email change migration is in [ap
 ## Exit criteria
 
 - [x] Scheduler implemented with Cron Trigger and integration test.
-- [x] E2E smoke test covers demo login → home → page → groups → logout (full register → create group → invite → edit flow requires group/page creation UI, which is not in Phase 7 scope).
+- [x] E2E smoke test covers login → home → page → groups → logout (full register → create group → invite → edit flow requires group/page creation UI, which is not in Phase 7 scope).
 - [x] `TRPC_REST_MAP.md` route audit: every endpoint marked "implemented" has a registered Hono route in `apps/api-worker`.
 - [x] Group password management UI (enable/change/disable) exists in `GroupDetailView.vue`.
 - [ ] Realtime notification toast or badge surfaces in the app shell (not just the `/notifications` page).

new-deepnotes/apps/api-worker/eslint.config.js

@@ -1,3 +1,8 @@
 import base from "../../eslint.config.js";
 
-export default [...base];
+export default [
+  {
+    ignores: ["dist/**"],
+  },
+  ...base,
+];

new-deepnotes/apps/api-worker/package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "build": "wrangler build",
     "dev": "wrangler dev",
-    "lint": "eslint .",
+    "lint": "eslint src",
     "typecheck": "tsc -p tsconfig.json --noEmit",
     "test": "vitest run"
   },

new-deepnotes/apps/api-worker/src/index.test.ts

@@ -26,7 +26,6 @@ describe("api-worker", () => {
     ["POST", "/api/sessions/login"],
     ["POST", "/api/sessions/refresh"],
     ["POST", "/api/sessions/logout"],
-    ["POST", "/api/sessions/demo"],
     ["GET", "/api/users/me/groups"],
     ["GET", "/api/users/me/pages/starting"],
     [

new-deepnotes/apps/api-worker/src/routes/pages.ts

@@ -344,7 +344,7 @@ app.get("/api/pages/:pageId/collab-ws", async (c) => {
   const db = getDbForConnectionString(hyper.connectionString);
   const cookieHeader = c.req.header("Cookie");
 
-  let summary: { userId: string; demo: boolean };
+  let summary: { userId: string };
   try {
     const { getAuthenticatedUserSummary, assertPageCollabWsConnectionAllowed } =
       await import("@deepnotes/session");
@@ -353,15 +353,6 @@ app.get("/api/pages/:pageId/collab-ws", async (c) => {
       env: sessionEnv,
       accessCookie: readCookieHeader(cookieHeader, "accessToken"),
     });
-    if (summary.demo) {
-      return c.json(
-        {
-          code: "FORBIDDEN",
-          message: "Demo sessions cannot use live collab WebSocket.",
-        },
-        403,
-      );
-    }
     await assertPageCollabWsConnectionAllowed({
       db,
       userId: summary.userId,

new-deepnotes/apps/api-worker/src/routes/realtime.ts

@@ -42,23 +42,14 @@ app.get("/api/realtime-ws", async (c) => {
   const db = getDbForConnectionString(hyper.connectionString);
   const cookieHeader = c.req.header("Cookie");
 
-  let summary: { userId: string; demo: boolean };
+  let summary: { userId: string };
   try {
     const { getAuthenticatedUserSummary } = await import("@deepnotes/session");
     summary = await getAuthenticatedUserSummary({
       db,
       env: sessionEnv,
       accessCookie: readCookieHeader(cookieHeader, "accessToken"),
     });
-    if (summary.demo) {
-      return c.json(
-        {
-          code: "FORBIDDEN",
-          message: "Demo sessions cannot use realtime WebSocket.",
-        },
-        403,
-      );
-    }
   } catch (e) {
     const { SessionError } = await import("@deepnotes/session");
     if (e instanceof SessionError) {

new-deepnotes/apps/api-worker/src/routes/sessions.ts

@@ -1,5 +1,5 @@
 import type { ContentfulStatusCode } from "hono/utils/http-status";
-import { sessionDemoRequestSchema, sessionLoginRequestSchema } from "@deepnotes/api";
+import { sessionLoginRequestSchema } from "@deepnotes/api";
 
 import type { ApiHono } from "../api-hono.js";
 import { readCookieHeader } from "../cookies.js";
@@ -163,63 +163,4 @@ app.post("/api/sessions/logout", async (c) => {
   return res;
 });
 
-app.post("/api/sessions/demo", async (c) => {
-  const sessionEnv = getSessionEnv(c.env);
-  if (sessionEnv == null) {
-    return c.json(serviceUnavailableBody, 503);
-  }
-  const hyper = c.env.HYPERDRIVE;
-  if (hyper == null) {
-    return c.json(
-      {
-        code: "SERVICE_UNAVAILABLE" as const,
-        message: "HYPERDRIVE binding is not configured.",
-      },
-      503,
-    );
-  }
-
-  let bodyJson: unknown;
-  try {
-    bodyJson = await c.req.json();
-  } catch {
-    return c.json({ code: "BAD_REQUEST", message: "Expected JSON body." }, 400);
-  }
-
-  const parsed = sessionDemoRequestSchema.safeParse(bodyJson);
-  if (!parsed.success) {
-    return c.json(
-      {
-        code: "VALIDATION_ERROR",
-        message: parsed.error.flatten().formErrors.join("; "),
-      },
-      400,
-    );
-  }
-
-  const db = getDbForConnectionString(hyper.connectionString);
-
-  try {
-    const { performSessionStartDemo } = await import("@deepnotes/session");
-    const { json, cookieLines } = await performSessionStartDemo({
-      db,
-      env: sessionEnv,
-      body: parsed.data,
-      clientIp: c.req.header("CF-Connecting-IP") ?? "127.0.0.1",
-      userAgent: c.req.header("User-Agent") ?? "",
-    });
-    const res = c.json(json, 200);
-    appendSetCookies(res, cookieLines);
-    return res;
-  } catch (e) {
-    const { SessionError } = await import("@deepnotes/session");
-    if (e instanceof SessionError) {
-      return c.json(
-        { code: e.code, message: e.message },
-        e.status as ContentfulStatusCode,
-      );
-    }
-    throw e;
-  }
-});
 }