You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-**Composable size** — `useGroupMembersDetail.ts` (103 lines) and `usePageCollabEditor.ts` (238 lines) are now under the 300-line limit. `useSpatialPage.ts` (308 lines) still exceeds by a small margin.
81
81
-**Auth: `rememberDevice` UI missing in login** — `LoginView.vue` has no "Remember this device" checkbox for 2FA login; users are re-prompted every time. API schema already supports it.
82
82
-**Auth: no distributed locking** — Legacy used Redlock (`user-lock:${userId}`) around password change, email change, and 2FA mutations. New code relies on DB transactions only.
- Count files in `@deepnotes/session` — 71 files (no new files since last audit). ⚠️
63
-
- No composable in `apps/web` exceeds 300 lines. ⚠️ — `useGroupMembersDetail.ts` (785), `usePageCollabEditor.ts` (431), `useSpatialPage.ts` (414) still exceed; refactor deferred to post-Phase 8.
62
+
- Count files in `@deepnotes/session` — 8 facade files (re-exports from `@deepnotes/session-core`, `@deepnotes/groups`, `@deepnotes/pages`, `@deepnotes/billing`, `@deepnotes/realtime`). ✅
63
+
- No composable in `apps/web` exceeds 300 lines. ⚠️ — `useSpatialPage.ts` (308 lines) is the only remaining composable over the limit; the others were refactored. Deferred to post-Phase 8.
64
64
- No `console.log` in production DO code; replace with structured logger or remove. ✅
65
65
66
66
---
@@ -94,9 +94,10 @@ A full evaluation of TOTP, password change, and email change migration is in [ap
94
94
-[x] E2E smoke test covers demo login → home → page → groups → logout (full register → create group → invite → edit flow requires group/page creation UI, which is not in Phase 7 scope).
95
95
-[x]`TRPC_REST_MAP.md` route audit: every endpoint marked "implemented" has a registered Hono route in `apps/api-worker`.
96
96
-[x] Group password management UI (enable/change/disable) exists in `GroupDetailView.vue`.
97
-
-[x] Realtime notification toast or badge surfaces in the app shell (not just the `/notifications` page).
97
+
-[] Realtime notification toast or badge surfaces in the app shell (not just the `/notifications` page).
98
98
-[x] Group password unlock is wired into the collab flow so users can enter a password when a protected group page is opened.
0 commit comments