Skip to content

Commit dbd66e9

Browse files
committed
docs: improve
1 parent cc14c19 commit dbd66e9

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

docs/restart-plan/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ A criterion is **not met** until the verification command or check passes in CI.
7777

7878
- **Marketing/help/pricing/whitepaper surfaces entirely missing**`apps/marketing` is a single-card placeholder. Launch blocker, not polish.
7979
- **Realtime notification toast** — only `/notifications` page exists, no badge/toast.
80-
- **Composable size**`useGroupMembersDetail.ts` (785 lines), `usePageCollabEditor.ts` (431 lines), `useSpatialPage.ts` (414 lines) exceed 300-line limit.
80+
- **Composable size**`useGroupMembersDetail.ts` (103 lines) and `usePageCollabEditor.ts` (238 lines) are now under the 300-line limit. `useSpatialPage.ts` (308 lines) still exceeds by a small margin.
8181
- **Auth: `rememberDevice` UI missing in login**`LoginView.vue` has no "Remember this device" checkbox for 2FA login; users are re-prompted every time. API schema already supports it.
8282
- **Auth: no distributed locking** — Legacy used Redlock (`user-lock:${userId}`) around password change, email change, and 2FA mutations. New code relies on DB transactions only.
8383

docs/restart-plan/phase-7-account-polish.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ All non-editor UX is polished and tested.
5959
- `pnpm typecheck` — 0 errors. ✅
6060
- `pnpm test` — 0 failures, 0 skips (134 web + 48 session + 0 api-worker = 182). ✅
6161
- Check `apps/api-worker` bundle size (`wrangler build`) — alert if > 500KB.
62-
- Count files in `@deepnotes/session`71 files (no new files since last audit). ⚠️
63-
- No composable in `apps/web` exceeds 300 lines. ⚠️ — `useGroupMembersDetail.ts` (785), `usePageCollabEditor.ts` (431), `useSpatialPage.ts` (414) still exceed; refactor deferred to post-Phase 8.
62+
- Count files in `@deepnotes/session`8 facade files (re-exports from `@deepnotes/session-core`, `@deepnotes/groups`, `@deepnotes/pages`, `@deepnotes/billing`, `@deepnotes/realtime`).
63+
- No composable in `apps/web` exceeds 300 lines. ⚠️ — `useSpatialPage.ts` (308 lines) is the only remaining composable over the limit; the others were refactored. Deferred to post-Phase 8.
6464
- No `console.log` in production DO code; replace with structured logger or remove. ✅
6565

6666
---
@@ -94,9 +94,10 @@ A full evaluation of TOTP, password change, and email change migration is in [ap
9494
- [x] E2E smoke test covers demo login → home → page → groups → logout (full register → create group → invite → edit flow requires group/page creation UI, which is not in Phase 7 scope).
9595
- [x] `TRPC_REST_MAP.md` route audit: every endpoint marked "implemented" has a registered Hono route in `apps/api-worker`.
9696
- [x] Group password management UI (enable/change/disable) exists in `GroupDetailView.vue`.
97-
- [x] Realtime notification toast or badge surfaces in the app shell (not just the `/notifications` page).
97+
- [ ] Realtime notification toast or badge surfaces in the app shell (not just the `/notifications` page).
9898
- [x] Group password unlock is wired into the collab flow so users can enter a password when a protected group page is opened.
9999
- [x] `@deepnotes/session` split into `@deepnotes/session-core`, `@deepnotes/groups`, `@deepnotes/pages`, `@deepnotes/billing`, `@deepnotes/realtime`; remaining `@deepnotes/session` ≤ 20 files.
100100
- [ ] Component-level tests for `AccountView.vue` and `GroupDetailView.vue` pass (deferred to post-Phase 8).
101101
- [x] `pnpm lint`, `pnpm typecheck`, `pnpm test` all pass with 0 errors/failures.
102-
- [x] No composable in `apps/web` exceeds 300 lines; no `console.log` in DO production code.
102+
- [x] No `console.log` in DO production code.
103+
- [ ] No composable in `apps/web` exceeds 300 lines — `useSpatialPage.ts` (308 lines) still slightly over.

0 commit comments

Comments
 (0)