Fixing Bug Bash Issues (microsoft#307)

Fixed issues from bug bash

Author: andreamah

src/base_circuitpython/board.py

@@ -5,7 +5,7 @@
 import terminal_handler
 
 
-class Display:
+class __Display:
     def __init__(self):
         self.active_group = None
         self.terminal = terminal_handler.Terminal()
@@ -25,7 +25,7 @@ def show(self, group=None):
                 group._Group__draw()
 
 
-DISPLAY = Display()
+DISPLAY = __Display()
 
 # default pin for neopixel,
 # shows that this could

src/base_circuitpython/displayio/group.py

@@ -336,5 +336,5 @@ def __len__(self):
     def pop(self, i=-1):
         item = self.__contents.pop(i)
         item.parent = None
-        self.elem_changed()
+        self.__elem_changed()
         return item

src/clue/adafruit_slideshow.py

@@ -7,10 +7,7 @@
 import time
 import collections
 from random import shuffle
-from common import utils
-from common import debugger_communication_client
-from common.telemetry import telemetry_py
-from common.telemetry_events import TelemetryEvent
+import common
 import board
 
 # taken from adafruit
@@ -157,7 +154,7 @@ def __init__(
         # if path is relative, this makes sure that
         # it's relative to the users's code file
         abs_path_parent_dir = os.path.abspath(
-            os.path.join(utils.abs_path_to_user_file, os.pardir)
+            os.path.join(common.utils.abs_path_to_user_file, os.pardir)
         )
         abs_path_folder = os.path.normpath(os.path.join(abs_path_parent_dir, folder))
 
@@ -176,7 +173,9 @@ def __init__(
         # show the first working image
         self.advance()
 
-        telemetry_py.send_telemetry(TelemetryEvent.CLUE_API_SLIDESHOW)
+        common.telemetry.telemetry_py.send_telemetry(
+            common.telemetry.TelemetryEvent.CLUE_API_SLIDESHOW
+        )
 
     @property
     def current_image_name(self):
@@ -382,9 +381,9 @@ def __send(self, img):
 
         sendable_json = {CONSTANTS.BASE_64: img_str}
 
-        if utils.debug_mode:
-            debugger_communication_client.debug_send_to_simulator(
+        if common.utils.debug_mode:
+            common.debugger_communication_client.debug_send_to_simulator(
                 sendable_json, CONSTANTS.CLUE
             )
         else:
-            utils.send_to_simulator(sendable_json, CONSTANTS.CLUE)
+            common.utils.send_to_simulator(sendable_json, CONSTANTS.CLUE)

src/common/debugger_communication_client.py

@@ -3,7 +3,11 @@
 
 import sys
 import json
+
+# WARNING: importing socketio will sometimes cause errors in normal execution
+# try to import common instead of common.debugger_communication_cleint
 import socketio
+
 import copy
 import pathlib