Fix multi-pwsh release naming and Windows metadata (#16)

## Summary
- rename release artifacts from `pwsh-multi-*` to `multi-pwsh-*`
- add Windows version resource metadata for `multi-pwsh.exe` and
`pwsh-host.exe`
- set company/copyright metadata to Devolutions Inc (2021-2026)
- silence non-Windows dead code warnings in named pipe command handling

## Validation
- `PwshExePath="$HOME/.pwsh/bin/pwsh-7.4" cargo check -p multi-pwsh -p
pwsh-host-cli`

Author: mamoreau-devolutions

.github/workflows/release.yml

@@ -24,47 +24,47 @@ jobs:
             target: x86_64-unknown-linux-gnu
             host_archive: pwsh-host-linux-x64.zip
             host_binary: pwsh-host
-            multi_archive: pwsh-multi-linux-x64.zip
+            multi_archive: multi-pwsh-linux-x64.zip
             multi_binary: multi-pwsh
 
           - name: linux-arm64
             os: ubuntu-latest
             target: aarch64-unknown-linux-gnu
             host_archive: pwsh-host-linux-arm64.zip
             host_binary: pwsh-host
-            multi_archive: pwsh-multi-linux-arm64.zip
+            multi_archive: multi-pwsh-linux-arm64.zip
             multi_binary: multi-pwsh
 
           - name: windows-x64
             os: windows-latest
             target: x86_64-pc-windows-msvc
             host_archive: pwsh-host-windows-x64.zip
             host_binary: pwsh-host.exe
-            multi_archive: pwsh-multi-windows-x64.zip
+            multi_archive: multi-pwsh-windows-x64.zip
             multi_binary: multi-pwsh.exe
 
           - name: windows-arm64
             os: windows-latest
             target: aarch64-pc-windows-msvc
             host_archive: pwsh-host-windows-arm64.zip
             host_binary: pwsh-host.exe
-            multi_archive: pwsh-multi-windows-arm64.zip
+            multi_archive: multi-pwsh-windows-arm64.zip
             multi_binary: multi-pwsh.exe
 
           - name: macos-x64
             os: macos-14
             target: x86_64-apple-darwin
             host_archive: pwsh-host-macos-x64.zip
             host_binary: pwsh-host
-            multi_archive: pwsh-multi-macos-x64.zip
+            multi_archive: multi-pwsh-macos-x64.zip
             multi_binary: multi-pwsh
 
           - name: macos-arm64
             os: macos-14
             target: aarch64-apple-darwin
             host_archive: pwsh-host-macos-arm64.zip
             host_binary: pwsh-host
-            multi_archive: pwsh-multi-macos-arm64.zip
+            multi_archive: multi-pwsh-macos-arm64.zip
             multi_binary: multi-pwsh
 
     steps:
@@ -163,7 +163,7 @@ jobs:
           path: ${{ matrix.host_archive }}
           if-no-files-found: error
 
-      - name: Upload pwsh-multi artifact
+      - name: Upload multi-pwsh artifact
         uses: actions/upload-artifact@v4
         with:
           name: ${{ matrix.multi_archive }}
@@ -196,7 +196,7 @@ jobs:
         working-directory: dist
         run: |
           $zipFiles = Get-ChildItem -Recurse -File |
-            Where-Object { $_.Name -like 'pwsh-host-*.zip' -or $_.Name -like 'pwsh-multi-*.zip' } |
+            Where-Object { $_.Name -like 'pwsh-host-*.zip' -or $_.Name -like 'multi-pwsh-*.zip' } |
             Sort-Object Name
 
           if (-not $zipFiles) {
@@ -222,7 +222,7 @@ jobs:
           RELEASE_TARGET: ${{ github.sha }}
         run: |
           $zipFiles = Get-ChildItem -Path dist -Recurse -File |
-            Where-Object { $_.Name -like 'pwsh-host-*.zip' -or $_.Name -like 'pwsh-multi-*.zip' } |
+            Where-Object { $_.Name -like 'pwsh-host-*.zip' -or $_.Name -like 'multi-pwsh-*.zip' } |
             Sort-Object Name |
             ForEach-Object { $_.FullName }
 

Cargo.lock

@@ -19,4 +19,7 @@ flate2 = "1.0"
 tar = "0.4"
 zip = { version = "0.6", default-features = false, features = ["deflate"] }
 home = "0.5"
-tempfile = "3.12"
+tempfile = "3.12"
+
+[build-dependencies]
+winresource = "0.1"

crates/multi-pwsh/Cargo.toml

@@ -0,0 +1,22 @@
+fn main() {
+    println!("cargo:rerun-if-env-changed=CARGO_PKG_VERSION");
+
+    if std::env::var_os("CARGO_CFG_WINDOWS").is_none() {
+        return;
+    }
+
+    let version = std::env::var("CARGO_PKG_VERSION").expect("missing CARGO_PKG_VERSION");
+
+    let mut resource = winresource::WindowsResource::new();
+    resource
+        .set("FileDescription", "Install and update side-by-side PowerShell versions")
+        .set("ProductName", "multi-pwsh")
+        .set("InternalName", "multi-pwsh")
+        .set("CompanyName", "Devolutions Inc")
+        .set("LegalCopyright", "Copyright 2021-2026 Devolutions Inc.")
+        .set("OriginalFilename", "multi-pwsh.exe")
+        .set("FileVersion", &version)
+        .set("ProductVersion", &version);
+
+    resource.compile().expect("failed to compile Windows resources");
+}

crates/multi-pwsh/build.rs

@@ -12,3 +12,6 @@ path = "src/main.rs"
 [dependencies]
 pwsh-host = { path = "../pwsh-host" }
 base64 = "0.22"
+
+[build-dependencies]
+winresource = "0.1"

crates/pwsh-host-cli/Cargo.toml

@@ -0,0 +1,22 @@
+fn main() {
+    println!("cargo:rerun-if-env-changed=CARGO_PKG_VERSION");
+
+    if std::env::var_os("CARGO_CFG_WINDOWS").is_none() {
+        return;
+    }
+
+    let version = std::env::var("CARGO_PKG_VERSION").expect("missing CARGO_PKG_VERSION");
+
+    let mut resource = winresource::WindowsResource::new();
+    resource
+        .set("FileDescription", "pwsh-compatible CLI backed by pwsh-host and hostfxr")
+        .set("ProductName", "pwsh-host")
+        .set("InternalName", "pwsh-host")
+        .set("CompanyName", "Devolutions Inc")
+        .set("LegalCopyright", "Copyright 2021-2026 Devolutions Inc.")
+        .set("OriginalFilename", "pwsh-host.exe")
+        .set("FileVersion", &version)
+        .set("ProductVersion", &version);
+
+    resource.compile().expect("failed to compile Windows resources");
+}

crates/pwsh-host-cli/build.rs

@@ -1,13 +1,14 @@
 use std::error::Error;
 use std::ffi::{OsStr, OsString};
 use std::fmt::{Display, Formatter};
-use std::time::Duration;
 
 use base64::{engine::general_purpose::STANDARD as BASE64_STANDARD, Engine as _};
 
 const NAMED_PIPE_COMMAND_FLAG: &str = "-namedpipecommand";
 const ENCODED_COMMAND_FLAG: &str = "-EncodedCommand";
-const PIPE_CONNECT_TIMEOUT: Duration = Duration::from_secs(3);
+#[cfg(windows)]
+const PIPE_CONNECT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(3);
+#[cfg(windows)]
 const MAX_COMMAND_BYTES: usize = 1024 * 1024;
 
 #[derive(Debug)]
@@ -126,7 +127,7 @@ fn read_named_pipe_command(pipe_name: &OsStr) -> Result<String, NamedPipeCommand
     use std::fs::OpenOptions;
     use std::io::Read;
     use std::thread::sleep;
-    use std::time::Instant;
+    use std::time::{Duration, Instant};
 
     let pipe_name = pipe_name.to_string_lossy();
     if pipe_name.trim().is_empty() {