Conversation
Created integration tests for board endpoints
ehammo
requested review from
CarlosRodrigo,
rodrigoperazzo and
viniciusalbuquerque
viniciusalbuquerque
left a comment
viniciusalbuquerque
left a comment
There was a problem hiding this comment.
I think we just need to be sure if topics would be an array.
| validateFullBoard (Board) { | ||
| Joi.validate(Board, Joi.object({ | ||
| id: Joi.string().required(), | ||
| topics: Joi.array().items(Joi.string()).required(), |
There was a problem hiding this comment.
I think 'topics' is not going to be an array. I think it's going to be a dictionary like:
{1: 'Less', 2: Keep, 3: 'More', 4: 'Start', 5: 'Stop'}
There was a problem hiding this comment.
It is. What I mean is that it won't be an array.
viniciusalbuquerque
left a comment
viniciusalbuquerque
left a comment
There was a problem hiding this comment.
Please make the changes with the new version of branch dev
|
|
||
| getRoutes () { | ||
| this.app.get('/', (req, res) => { | ||
| this.genericRouter.execute(this.boardController.getAllBoards |
There was a problem hiding this comment.
Code changed and you either have to use executeOld or pass a mapper to the execute function
There was a problem hiding this comment.
Same thing for all of the definitions here in this file
| } | ||
|
|
||
| // todo : remove unused params | ||
| // eslint-disable-next-line no-use-before-define |
There was a problem hiding this comment.
Remove comments
2 participants
Added Board CRUD following the new arch/style
Created integration tests for board endpoints