Issue #71: Create logic to handle meetings creation#85
Open
jvpessoa10 wants to merge 1 commit into
Open
Conversation
CarlosRodrigo
requested changes
Feb 5, 2020
Member
CarlosRodrigo
left a comment
CarlosRodrigo
left a comment
There was a problem hiding this comment.
Please change the branch to dev.
Also, make sure you are using your personal email on commit :)
One last thing, if you could, please add some tests. You can find the integration ones under src/api and one for each route should be enough.
CarlosRodrigo
requested changes
Apr 8, 2020
Comment on lines
+26
to
+31
| // for (let i = 0; i < meetings.length; i++) { | ||
| // const filter = { meeting_id: meetings[i].id } | ||
| // console.log(filter) | ||
| // meetings[i]['sessions'] = await this.sessionsRepository | ||
| // .newGetSession(filter) | ||
| // } |
Member
There was a problem hiding this comment.
Please remove commented code.
jvpessoa10
requested review from
CGSILVA,
CarlosRodrigo,
ehammo and
victorrattis
viniciusalbuquerque
requested changes
Feb 26, 2021
| } | ||
| getRoutes () { | ||
| this.app.post('/', async (req, res) => { | ||
| await this.genericRouter.execute(this.meetingsController.insertMeeting |
Contributor
There was a problem hiding this comment.
This code has changed and you now need to pass a mapper into the execute function or use executeOld function (which is discouraged because we want to deprecate that)
Contributor
There was a problem hiding this comment.
Same comment for all of the functions in this router
| @@ -0,0 +1,6 @@ | |||
| const Joi = require('joi') | |||
|
|
|||
| module.exports = Joi.object().keys({ | |||
Contributor
There was a problem hiding this comment.
Do we need to add this teamsSchema now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.