fix(embyfin-stream-cleanup): downgrade repeated identifier overlap log from INFO to DEBUG#99
Closed
nemesbak wants to merge 1 commit into
Closed
Conversation
_get_media_server_configs() is called multiple times per poll cycle (once in _poll_once, once in _fetch_media_server_sessions, once in _fetch_active_recording_channels). When two media servers share an identifier (e.g. the same Jellyfin instance registered for both pool entries), the "pools will be combined" message fires at INFO level on every single call — generating up to ~18 log lines per minute of identical text in normal operation. Downgrade to DEBUG so the message is available for troubleshooting without polluting INFO logs during steady-state operation.
dispatcharr-plugins-bot
Bot
added
the
Plugin Update
Plugin Validation ResultsModified plugins: 1 PR Closed: UnauthorizedYour GitHub username ( If you are submitting a new plugin, add your GitHub username to the |
dispatcharr-plugins-bot
Bot
added
the
Invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_get_media_server_configs()is called multiple times per poll cycle: once in_poll_once(), once in_fetch_media_server_sessions(), and once in_fetch_active_recording_channels(). When two configured media servers share any identifier (e.g. the same Jellyfin IP registered for multiple server slots), the message:fires at
INFOlevel on every single call — up to 3 times per poll interval (default 10 seconds), generating ~18 identical log lines per minute during normal steady-state operation.Fix
Downgrade from
logger.info(...)tologger.debug(...). The information is still fully available for troubleshooting by enabling DEBUG logging; it just does not appear in normal INFO-level logs.Context
Discovered while reviewing log output after updating to v1.2.0 with two Jellyfin servers pointing to the same host (
192.168.1.25), both sharing that IP as their identifier. Related issue filed in the main Dispatcharr repo: Dispatcharr/Dispatcharr#1297.