-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: drop deprecated Twist-era date-range params #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { http, HttpResponse } from 'msw' | ||
| import { describe, expect, it } from 'vitest' | ||
| import { CommsApi } from '../comms-api' | ||
| import { server } from '../testUtils/msw-setup' | ||
| import { TEST_API_BASE_URL as BASE, TEST_API_TOKEN } from '../testUtils/test-defaults' | ||
|
|
||
| // Pins the wire shape of `inbox-client` after the deprecated `since` / | ||
| // `until` aliases were dropped — both serialization paths (URL params | ||
| // for `getInbox`, body for `archiveAll`) need explicit coverage. | ||
|
|
||
| describe('InboxClient — wire serialization', () => { | ||
| it('getInbox sends workspace_id / newer_than_ts / older_than_ts on the URL', async () => { | ||
| const capturedUrls: URL[] = [] | ||
| server.use( | ||
| http.get(`${BASE}/inbox/get`, ({ request }) => { | ||
| capturedUrls.push(new URL(request.url)) | ||
| return HttpResponse.json([]) | ||
| }), | ||
| ) | ||
|
|
||
| const api = new CommsApi(TEST_API_TOKEN) | ||
| await api.inbox.getInbox({ | ||
| workspaceId: 1, | ||
| newerThan: new Date('2026-01-01T00:00:00Z'), | ||
| olderThan: new Date('2026-02-01T00:00:00Z'), | ||
| limit: 25, | ||
| archiveFilter: 'all', | ||
| }) | ||
|
|
||
| expect(capturedUrls).toHaveLength(1) | ||
| const params = (capturedUrls[0] as URL).searchParams | ||
| expect(params.get('workspace_id')).toBe('1') | ||
| expect(params.get('newer_than_ts')).toBe( | ||
| String(Math.floor(new Date('2026-01-01T00:00:00Z').getTime() / 1000)), | ||
| ) | ||
| expect(params.get('older_than_ts')).toBe( | ||
| String(Math.floor(new Date('2026-02-01T00:00:00Z').getTime() / 1000)), | ||
| ) | ||
| expect(params.get('limit')).toBe('25') | ||
| expect(params.get('archive_filter')).toBe('all') | ||
| }) | ||
|
|
||
| it('archiveAll POSTs workspace_id and older_than_ts as snake_case', async () => { | ||
| let capturedBody: Record<string, unknown> | null = null | ||
| server.use( | ||
| http.post(`${BASE}/inbox/archive_all`, async ({ request }) => { | ||
| capturedBody = (await request.json()) as Record<string, unknown> | ||
| return HttpResponse.json({ status: 'ok' }) | ||
| }), | ||
| ) | ||
|
|
||
| const api = new CommsApi(TEST_API_TOKEN) | ||
| await api.inbox.archiveAll({ | ||
| workspaceId: 1, | ||
| olderThan: new Date('2026-02-01T00:00:00Z'), | ||
| }) | ||
|
|
||
| expect(capturedBody).toEqual({ | ||
| workspace_id: 1, | ||
| older_than_ts: Math.floor(new Date('2026-02-01T00:00:00Z').getTime() / 1000), | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { http, HttpResponse } from 'msw' | ||
| import { describe, expect, it } from 'vitest' | ||
| import { CommsApi } from '../comms-api' | ||
| import { server } from '../testUtils/msw-setup' | ||
| import { TEST_API_BASE_URL as BASE, TEST_API_TOKEN } from '../testUtils/test-defaults' | ||
|
|
||
| // Pins the wire shape of `threads-client`. The PR that dropped the | ||
| // `newer_than_ts` / `older_than_ts` aliases also tightened how `params` | ||
| // is built — this test catches both a casing regression and any | ||
| // accidental forwarding of unknown keys. | ||
|
|
||
| describe('ThreadsClient — wire serialization', () => { | ||
| it('getThreads sends workspace_id / channel_id / newer_than_ts / older_than_ts on the URL', async () => { | ||
| const capturedUrls: URL[] = [] | ||
| server.use( | ||
| http.get(`${BASE}/threads/get`, ({ request }) => { | ||
| capturedUrls.push(new URL(request.url)) | ||
| return HttpResponse.json([]) | ||
| }), | ||
| ) | ||
|
|
||
| const api = new CommsApi(TEST_API_TOKEN) | ||
| await api.threads.getThreads({ | ||
| workspaceId: 1, | ||
| channelId: '7YpL3oZ4kZ9vP7Q1tR2sX44', | ||
| archived: false, | ||
| newerThan: new Date('2026-01-01T00:00:00Z'), | ||
| olderThan: new Date('2026-02-01T00:00:00Z'), | ||
| limit: 50, | ||
| }) | ||
|
|
||
| expect(capturedUrls).toHaveLength(1) | ||
| const params = (capturedUrls[0] as URL).searchParams | ||
| expect(params.get('workspace_id')).toBe('1') | ||
| expect(params.get('channel_id')).toBe('7YpL3oZ4kZ9vP7Q1tR2sX44') | ||
| expect(params.get('archived')).toBe('false') | ||
| expect(params.get('newer_than_ts')).toBe( | ||
| String(Math.floor(new Date('2026-01-01T00:00:00Z').getTime() / 1000)), | ||
| ) | ||
| expect(params.get('older_than_ts')).toBe( | ||
| String(Math.floor(new Date('2026-02-01T00:00:00Z').getTime() / 1000)), | ||
| ) | ||
| expect(params.get('limit')).toBe('50') | ||
| }) | ||
|
|
||
| it('getThreads ignores legacy snake_case keys passed at runtime', async () => { | ||
| const capturedUrls: URL[] = [] | ||
| server.use( | ||
| http.get(`${BASE}/threads/get`, ({ request }) => { | ||
| capturedUrls.push(new URL(request.url)) | ||
| return HttpResponse.json([]) | ||
| }), | ||
| ) | ||
|
|
||
| const api = new CommsApi(TEST_API_TOKEN) | ||
| await api.threads.getThreads({ | ||
| workspaceId: 1, | ||
| // biome-ignore lint/suspicious/noExplicitAny: legacy-shape forced through `any` | ||
| ...({ newer_than_ts: 999, older_than_ts: 888 } as any), | ||
| }) | ||
|
|
||
| const params = (capturedUrls[0] as URL).searchParams | ||
| expect(params.get('newer_than_ts')).toBeNull() | ||
| expect(params.get('older_than_ts')).toBeNull() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.