feat!: convert react-interpolate to TypeScript#55
Merged
Conversation
doistbot
reviewed
May 21, 2026
Member
doistbot
left a comment
There was a problem hiding this comment.
This PR successfully converts react-interpolate to TypeScript, updating the build tooling and tightening the AST and parser typings while preserving the existing CJS and ESM entry points. This is a highly valuable upgrade that establishes a stricter, more reliable foundation for future development. A few areas have been flagged for further review, including managing Babel runtime dependencies, ensuring type compatibility for CommonJS consumers, narrowing overly broad types, and addressing a few minor performance, test isolation, and infinite loop edge cases.
|
🔥 ✅ |
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts
react-interpolatesource and tests to TypeScript, replaces the handwritten declaration file with generated declarations, and updates the existing build/test tooling to support TS inputs.It also tightens the parser/token/AST typing model and enables stricter TypeScript compiler checks, including isolated declaration emit.
The published CJS and ESM entry points are preserved, and runtime behavior was compared against
v2.2.2for documented usage.Validation:
npm run typecheck,npm run lint,npm test -- --runInBand, andnpm run build.Reference