Skip to content

chore: replace prettier and eslint with oxfmt and oxlint#57

Merged
gnapse merged 2 commits into
nextfrom
ernesto/use-oxfmt-oxlint
May 21, 2026
Merged

chore: replace prettier and eslint with oxfmt and oxlint#57
gnapse merged 2 commits into
nextfrom
ernesto/use-oxfmt-oxlint

Conversation

@gnapse
Copy link
Copy Markdown

@gnapse gnapse commented May 21, 2026

Summary

This replaces the repo's Prettier and ESLint tooling with oxfmt and oxlint by updating the package scripts and dev dependencies, adding .oxlintrc.jsonc, and removing .eslintrc. The oxfmt and oxlint configs were copied over from Doist/typist.

It also updates the "pull request" and "publish" workflows to run npm run check, so formatting, linting, and type-checking are enforced together in CI.

Because oxfmt was applied across the repository, the branch includes a one-time formatting sweep over source, tests, docs, and config files, plus small fixture updates to keep Oxlint and the package smoke tests passing. This keeps the library aligned with Doist's newer JS tooling while preserving the existing build and test flow.

Reference

Validation

  • npm run check
  • npm test -- --runInBand
  • npm run build

@gnapse gnapse marked this pull request as ready for review May 21, 2026 20:28
@gnapse gnapse self-assigned this May 21, 2026
@gnapse gnapse changed the title [codex] Replace prettier and eslint with oxfmt and oxlint chore: replace prettier and eslint with oxfmt and oxlint May 21, 2026
@gnapse gnapse force-pushed the ernesto/use-oxfmt-oxlint branch from 4644f44 to b8b247d Compare May 21, 2026 20:31
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR nicely updates the repository's tooling by replacing Prettier and ESLint with oxfmt and oxlint, alongside a comprehensive formatting sweep and updated CI workflows. These changes successfully align the library with modern JavaScript tooling standards while keeping the existing build and test flows intact. However, a minor adjustment is needed in the package smoke tests to ensure the CJS default export remains properly validated as a callable function.

Share FeedbackReview Logs

Comment thread __test__/package-types.cts Outdated
@gnapse gnapse requested review from a team and frankieyan and removed request for a team May 21, 2026 20:43
@gnapse gnapse merged commit 6207a8d into next May 21, 2026
2 checks passed
@gnapse gnapse deleted the ernesto/use-oxfmt-oxlint branch May 21, 2026 20:44
Copy link
Copy Markdown
Member

@frankieyan frankieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good ✅

Because oxfmt was applied across the repository, the branch includes a one-time formatting sweep over source, tests, docs, and config files, plus small fixture updates to keep Oxlint and the package smoke tests passing. This keeps the library aligned with Doist's newer JS tooling while preserving the existing build and test flow.

Small nit: the formatting changes would be better kept in its own commit to separate the "real" changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants