chore: replace prettier and eslint with oxfmt and oxlint#57
Conversation
4644f44 to
b8b247d
Compare
doistbot
left a comment
There was a problem hiding this comment.
This PR nicely updates the repository's tooling by replacing Prettier and ESLint with oxfmt and oxlint, alongside a comprehensive formatting sweep and updated CI workflows. These changes successfully align the library with modern JavaScript tooling standards while keeping the existing build and test flows intact. However, a minor adjustment is needed in the package smoke tests to ensure the CJS default export remains properly validated as a callable function.
frankieyan
left a comment
There was a problem hiding this comment.
Changes look good ✅
Because oxfmt was applied across the repository, the branch includes a one-time formatting sweep over source, tests, docs, and config files, plus small fixture updates to keep Oxlint and the package smoke tests passing. This keeps the library aligned with Doist's newer JS tooling while preserving the existing build and test flow.
Small nit: the formatting changes would be better kept in its own commit to separate the "real" changes.
Summary
This replaces the repo's Prettier and ESLint tooling with
oxfmtandoxlintby updating the package scripts and dev dependencies, adding.oxlintrc.jsonc, and removing.eslintrc. Theoxfmtandoxlintconfigs were copied over from Doist/typist.It also updates the "pull request" and "publish" workflows to run
npm run check, so formatting, linting, and type-checking are enforced together in CI.Because
oxfmtwas applied across the repository, the branch includes a one-time formatting sweep over source, tests, docs, and config files, plus small fixture updates to keep Oxlint and the package smoke tests passing. This keeps the library aligned with Doist's newer JS tooling while preserving the existing build and test flow.Reference
Validation
npm run checknpm test -- --runInBandnpm run build