Skip to content

Fix pagination overwriting#1188

Merged
Tomas-Ka merged 2 commits into
new-designfrom
new-design-pagination-overwrite-fix
May 18, 2026
Merged

Fix pagination overwriting#1188
Tomas-Ka merged 2 commits into
new-designfrom
new-design-pagination-overwrite-fix

Conversation

@Tomas-Ka
Copy link
Copy Markdown
Contributor

🧩 Summary

Fixes an issue where pagination overwrites all search params apart from the one it's setting.

🔗 Related issues (if any)

Closes #1176

This makes sure to get the value of the search params and adding /
changing them instead of just overwriting them.
@Tomas-Ka
Copy link
Copy Markdown
Contributor Author

@SLUCHABLUB does this satisfy your issue?
@fgren as the original author of the Pagination component, does this look ok?

Copy link
Copy Markdown
Contributor

@SLUCHABLUB SLUCHABLUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

Comment thread src/lib/components/Pagination.svelte Outdated
@Tomas-Ka Tomas-Ka requested a review from SLUCHABLUB May 18, 2026 11:17
Copy link
Copy Markdown
Contributor

@SLUCHABLUB SLUCHABLUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Tomas-Ka Tomas-Ka merged commit 2c17c87 into new-design May 18, 2026
1 check passed
@Tomas-Ka Tomas-Ka deleted the new-design-pagination-overwrite-fix branch May 18, 2026 23:04
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Done in CPU May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants