Skip to content

DYN-10455 Update agent skills#17088

Merged
avidit merged 4 commits into
DynamoDS:masterfrom
avidit:dyn-10455
May 19, 2026
Merged

DYN-10455 Update agent skills#17088
avidit merged 4 commits into
DynamoDS:masterfrom
avidit:dyn-10455

Conversation

@avidit
Copy link
Copy Markdown
Contributor

@avidit avidit commented Apr 30, 2026

Purpose

DYN-10455: Migrate canonical agent skills and rules from the .agents/ directory to .claude/, aligning with the Claude Code standard directory convention.

Key changes:

  • All skill files moved from .agents/skills/ → .claude/skills/ and rules from .agents/rules/ → .claude/rules/ (renames only, no content changes to most)
  • .agents/README.md replaced by .claude/README.md with updated structure and skill table
  • .github/copilot-instructions.md and AGENTS.md updated to reference new .claude/ paths
  • sync_agent_wrappers.ps1 updated to source skills from .claude/skills/ and simplified generated wrapper template (removed redundant boilerplate prose)
  • All .github/agents/*.agent.md wrappers regenerated to match the simplified template
  • dynamo-skill-writer/SKILL.md updated with content changes

No public API changes. No new nodes. No production code modified.

Declarations

Check these if you believe they are true

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copilot AI review requested due to automatic review settings April 30, 2026 21:09
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10455

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Dynamo’s canonical AI agent skills/rules from .agents/ to the Claude Code–standard .claude/ layout, updates references, and regenerates Copilot wrapper agents to point at the new canonical sources.

Changes:

  • Moved canonical skills/rules into .claude/ and removed .agents/README.md.
  • Updated repo docs and Copilot instructions to reference .claude/ paths.
  • Updated the wrapper sync script and regenerated .github/agents/*.agent.md wrappers; adjusted .gitignore and added a VS Code extension recommendation file.

Reviewed changes

Copilot reviewed 20 out of 60 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AGENTS.md Updates agent guidance links from .agents/ to .claude/.
.vscode/extensions.json Adds recommended VS Code extension (ms-dotnettools.csdevkit).
.gitignore Ignores most of .vscode/ and .claude/ but keeps selected tracked files/dirs.
.github/scripts/sync_agent_wrappers.ps1 Points wrapper generation at .claude/skills/ and simplifies wrapper content template.
.github/copilot-instructions.md Updates skill/rule reference paths to .claude/.
.github/agents/dynamo-webview-component-scaffold.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-ux-designer.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-unit-testing.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-skill-writer.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-pr-description.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-onboarding.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-jira-ticket.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-ecosystem-reviewer.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-dotnet-janitor.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-dotnet-expert.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-content-designer.agent.md Regenerated wrapper pointing at .claude/skills/....
.github/agents/dynamo-codebase-patterns.agent.md Regenerated wrapper pointing at .claude/skills/....
.claude/skills/dynamo-webview-component-scaffold/SKILL.md Adds canonical skill content under .claude/skills/.
.claude/skills/dynamo-ux-designer/SKILL.md Adds canonical skill content under .claude/skills/.
.claude/skills/dynamo-unit-testing/SKILL.md Adds canonical skill content under .claude/skills/.
.claude/skills/dynamo-unit-testing/references/quality-checklist.md Adds unit-testing reference material.
.claude/skills/dynamo-unit-testing/assets/test-patterns.md Adds unit-testing templates/pattern examples.
.claude/skills/dynamo-skill-writer/SKILL.md Updates canonical skill-writer guidance for .claude/ layout and sync workflow.
.claude/skills/dynamo-pr-description/SKILL.md Adds canonical PR-description skill under .claude/skills/.
.claude/skills/dynamo-onboarding/SKILL.md Adds canonical onboarding skill under .claude/skills/.
.claude/skills/dynamo-jira-ticket/assets/template.md Adds canonical Jira ticket template asset.
.claude/skills/dynamo-jira-ticket/SKILL.md Adds canonical Jira ticket skill under .claude/skills/.
.claude/skills/dynamo-ecosystem-reviewer/SKILL.md Adds canonical ecosystem reviewer skill under .claude/skills/.
.claude/skills/dynamo-dotnet-janitor/SKILL.md Adds canonical .NET janitor skill under .claude/skills/.
.claude/skills/dynamo-dotnet-expert/references/quality-checklist.md Adds .NET expert reference checklist.
.claude/skills/dynamo-dotnet-expert/assets/publicapi-guide.md Adds PublicAPI guidance asset.
.claude/skills/dynamo-dotnet-expert/assets/csharp-patterns.md Adds C# patterns reference asset.
.claude/skills/dynamo-dotnet-expert/SKILL.md Adds canonical .NET expert skill under .claude/skills/.
.claude/skills/dynamo-content-designer/assets/ui-content.md Adds content design guidance asset.
.claude/skills/dynamo-content-designer/assets/tutorials-user-guides.md Adds tutorials/user guides templates.
.claude/skills/dynamo-content-designer/assets/release-notes.md Adds release notes guidance asset.
.claude/skills/dynamo-content-designer/assets/node-errors-warnings.md Adds node error/warning writing guidance asset.
.claude/skills/dynamo-content-designer/assets/node-descriptions.md Adds node description guidance asset.
.claude/skills/dynamo-content-designer/assets/feature-documentation.md Adds feature documentation guidance asset.
.claude/skills/dynamo-content-designer/assets/blog-posts.md Adds blog post structure guidance asset.
.claude/skills/dynamo-content-designer/SKILL.md Adds canonical content-designer skill under .claude/skills/.
.claude/skills/dynamo-codebase-patterns/patterns/dp-015-property-change-manager.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-014-asynctask-canmergewith.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-013-isvisibleindynamolibrary.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-012-dispose-derived-geometry.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-011-arbitrary-dimension-array.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-010-keepreference-ffi.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-009-workspace-type-guard.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-008-viewextension-lifecycle.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-007-task-completion-scheduler-thread.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-006-asynctask-two-phase-init.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-003-dynamowebview2-init-sequence.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-002-raises-modification-events.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/dp-001-register-all-ports.md Adds codebase pattern documentation file.
.claude/skills/dynamo-codebase-patterns/patterns/README.md Adds documentation for the patterns catalog.
.claude/skills/dynamo-codebase-patterns/SKILL.md Adds canonical codebase-patterns skill under .claude/skills/.
.claude/settings.json Adds .claude settings file.
.claude/rules/dynamo-core-rules.md Adds always-on Dynamo core rules under .claude/rules/.
.claude/README.md Adds .claude directory overview and usage guidance.
.agents/README.md Removes the old .agents/ canonical README (migration).

Comment on lines 103 to 106
---

# $title

This is a thin compatibility wrapper for the canonical skill.

Canonical source of truth:
- $canonicalPath

Usage guidance:
- Apply the full instructions from the canonical skill file above.
- If this wrapper and the canonical skill ever differ, the canonical skill wins.

Maintenance note:
- Keep this file lightweight to avoid drift across tools (Copilot/Cursor/Claude).
[$title]($canonicalPath)

Comment thread .github/copilot-instructions.md Outdated
Comment thread .claude/README.md
Comment on lines +13 to +17
├── rules/ # Always-on coding rules
│ └── dynamo-core-rules.md
├── agents/ # Subagents (specialized, with own tools/context)
│ └── security-analyzer.md
└── README.md # This file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth looking at

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Dynamo’s canonical agent skills/rules from the legacy .agents/ structure to the Claude Code standard .claude/ layout, updates references, and regenerates Copilot wrapper agents accordingly.

Changes:

  • Moved canonical skill/rule content to .claude/ and removed the legacy .agents/README.md.
  • Updated docs and tooling to reference .claude/ (including wrapper generation and regenerated .github/agents/*).
  • Added repo config updates for editor tooling and ignored files (.vscode/extensions.json, updated .gitignore).

Reviewed changes

Copilot reviewed 20 out of 60 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AGENTS.md Updates guidance links from .agents/ to .claude/.
.vscode/extensions.json Adds VS Code extension recommendation for C# dev kit.
.gitignore Refines ignore rules to allow tracking select .vscode/ and .claude/ files.
.github/scripts/sync_agent_wrappers.ps1 Switches canonical skill source to .claude/skills/ and simplifies wrapper output to a relative link.
.github/copilot-instructions.md Updates documentation pointers to .claude/README.md and .claude/* paths.
.github/agents/dynamo-webview-component-scaffold.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-ux-designer.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-unit-testing.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-skill-writer.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-pr-description.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-onboarding.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-jira-ticket.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-ecosystem-reviewer.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-dotnet-janitor.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-dotnet-expert.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-content-designer.agent.md Regenerated wrapper linking to canonical .claude skill.
.github/agents/dynamo-codebase-patterns.agent.md Regenerated wrapper linking to canonical .claude skill.
.claude/skills/dynamo-webview-component-scaffold/SKILL.md Adds canonical skill content under .claude/.
.claude/skills/dynamo-ux-designer/SKILL.md Adds canonical skill content under .claude/.
.claude/skills/dynamo-unit-testing/SKILL.md Adds canonical skill entrypoint and links to new reference assets.
.claude/skills/dynamo-unit-testing/assets/test-patterns.md Adds unit testing patterns/templates reference.
.claude/skills/dynamo-unit-testing/references/quality-checklist.md Adds unit testing quality checklist/anti-patterns reference.
.claude/skills/dynamo-skill-writer/SKILL.md Updates skill-writer guidance to reference .claude/ and wrapper sync changes.
.claude/skills/dynamo-pr-description/SKILL.md Adds canonical PR description skill under .claude/.
.claude/skills/dynamo-onboarding/SKILL.md Adds canonical onboarding skill under .claude/.
.claude/skills/dynamo-jira-ticket/SKILL.md Adds canonical Jira ticket skill under .claude/.
.claude/skills/dynamo-jira-ticket/assets/template.md Adds canonical Jira ticket template asset.
.claude/skills/dynamo-ecosystem-reviewer/SKILL.md Adds canonical ecosystem review skill under .claude/.
.claude/skills/dynamo-dotnet-janitor/SKILL.md Adds canonical .NET janitor skill under .claude/.
.claude/skills/dynamo-dotnet-expert/SKILL.md Adds canonical .NET expert skill under .claude/ and links to references.
.claude/skills/dynamo-dotnet-expert/assets/csharp-patterns.md Adds C# patterns reference asset.
.claude/skills/dynamo-dotnet-expert/assets/publicapi-guide.md Adds PublicAPI management reference asset.
.claude/skills/dynamo-dotnet-expert/references/quality-checklist.md Adds .NET quality checklist reference asset.
.claude/skills/dynamo-content-designer/SKILL.md Adds canonical content designer skill under .claude/ and links to writing assets.
.claude/skills/dynamo-content-designer/assets/ui-content.md Adds UI content guidelines asset.
.claude/skills/dynamo-content-designer/assets/tutorials-user-guides.md Adds tutorials/user guide templates asset.
.claude/skills/dynamo-content-designer/assets/release-notes.md Adds release notes guidance asset.
.claude/skills/dynamo-content-designer/assets/node-errors-warnings.md Adds node error/warning writing guidance asset.
.claude/skills/dynamo-content-designer/assets/node-descriptions.md Adds node description writing guidance asset.
.claude/skills/dynamo-content-designer/assets/feature-documentation.md Adds feature documentation guidance asset.
.claude/skills/dynamo-content-designer/assets/blog-posts.md Adds blog post guidance asset.
.claude/skills/dynamo-codebase-patterns/SKILL.md Adds canonical codebase-patterns skill under .claude/.
.claude/skills/dynamo-codebase-patterns/patterns/README.md Adds patterns catalog README under .claude/ skill.
.claude/skills/dynamo-codebase-patterns/patterns/dp-001-register-all-ports.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-002-raises-modification-events.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-003-dynamowebview2-init-sequence.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-006-asynctask-two-phase-init.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-007-task-completion-scheduler-thread.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-008-viewextension-lifecycle.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-009-workspace-type-guard.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-010-keepreference-ffi.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-011-arbitrary-dimension-array.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-012-dispose-derived-geometry.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-013-isvisibleindynamolibrary.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-014-asynctask-canmergewith.md Adds documented Dynamo pattern entry.
.claude/skills/dynamo-codebase-patterns/patterns/dp-015-property-change-manager.md Adds documented Dynamo pattern entry.
.claude/rules/dynamo-core-rules.md Adds canonical always-on C#/.NET rules under .claude/.
.claude/settings.json Adds Claude settings file.
.claude/README.md Adds .claude/ index/usage guidance and wrapper sync instructions.
.agents/README.md Removes legacy .agents/ README.

Comment on lines 4 to 6
Modes:
- default: regenerate mapped wrappers in .github/agents from canonical skills in .agents/skills
- default: regenerate mapped wrappers in .github/agents from canonical skills in .claude/skills
- -Check: validate mapped wrappers exist and match generated output, then detect orphan generated wrappers
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid

Copy link
Copy Markdown
Member

@johnpierson johnpierson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me.

@avidit avidit requested review from QilongTang and zeusongit April 30, 2026 22:28
Comment thread .vscode/extensions.json
"recommendations": [
"ms-dotnettools.csdevkit"
]
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this vscode will simply recommend user to install the extension when they open the repository in vscode.

- Update validate_agent_skills.yml to watch .claude/skills/** (was .agents/skills/**)
  and set SKILLS_DIR to .claude/skills (was .agents/skills) to align with migration
- Remove 'subagents' from .claude/README.md description line since no .claude/agents/
  directory exists

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 61 changed files in this pull request and generated 2 comments.

Comment thread .claude/README.md
Comment on lines +9 to +14
.claude/
├── skills/ # Canonical agent skills (agentskills.io format)
│ └── <name>/
│ └── SKILL.md
├── rules/ # Always-on coding rules
│ └── <rule-name>.md
Comment on lines +100 to +103
# Compute a link path relative to the wrapper file so GitHub resolves it correctly.
$wrapperDir = Split-Path -Parent $wrapperRelativePath
$linkPath = [System.IO.Path]::GetRelativePath($wrapperDir, $canonicalPath).Replace("\", "/")

@sonarqubecloud
Copy link
Copy Markdown

@avidit avidit merged commit cbd5c25 into DynamoDS:master May 19, 2026
28 of 31 checks passed
@avidit avidit deleted the dyn-10455 branch May 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants