-
Notifications
You must be signed in to change notification settings - Fork 670
DYN-: Dyn 9702 templates to home screen #17107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e3fb926
7aec4f3
7fde2d7
cb1454c
2189df6
1739ed2
e8ecae4
d445a53
3236104
09b9a97
36f0768
99a0538
eec3510
4e7fd6b
533156c
7c38dd6
8fb554c
859da9d
6689e5c
f83703f
595057c
9412121
dac3c59
22646e4
8d3a1ca
ae933cf
5e26a96
9035c81
fb71bd3
4b987db
697673b
a52f6fd
2360354
40bfbcc
961db9a
c31a4f6
cac9297
d7e142b
7e900f7
bd4bab7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2378,8 +2378,15 @@ | |
|
|
||
| private bool CanOpen(object parameters) | ||
| { | ||
|
|
||
| var filePath = parameters as string; | ||
| string filePath = parameters as string; | ||
|
Check warning on line 2381 in src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
|
||
| if (filePath == null && parameters is Tuple<string, bool> packedTwo) | ||
| { | ||
| filePath = packedTwo.Item1; | ||
| } | ||
| else if (filePath == null && parameters is Tuple<string, bool, bool> packedThree) | ||
| { | ||
| filePath = packedThree.Item1; | ||
| } | ||
|
Comment on lines
+2381
to
+2389
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I Added a focused test for OpenCommand.CanExecute with the Tuple<string, bool, bool> template parameter shape. |
||
|
|
||
| if (!PathHelper.IsValidPath(filePath)) | ||
| { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to compare template paths instead of relying on StartPageListItem reference equality. I used a case-insensitive comparison since these are Windows file paths.