DYN-10517: Fix define data test#17115
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10517
kalunkuo
requested review from
RobertGlobant20 and
mjkkirschner
and removed request for
Copilot
|
|
build passed in the next job, not sure why Dynamo SelfServe is waiting for results. |
There was a problem hiding this comment.
Pull request overview
This PR fixes crashes in DynamoCore unit tests related to the DefineData node by ensuring required core libraries are preloaded for the test fixture and by explicitly testing the “no selection” dropdown state.
Changes:
- Preload
DesignScriptBuiltin.dll(in addition toDSCoreNodes.dll) forDefineDataTeststo prevent test-time crashes due to missing library initialization. - Update
ValueTypeIdSafeWhenNoSelectionto explicitly setSelectedIndex = -1before accessingValueTypeId.
pullRequestValidation looks good. I have rebuild the smoke test job. |
@avidit Dynamo Smoke Test check still failing |
Feel free to merge it. The smoke tests failure was Jenkins issue |
Purpose
Fixed a crash when running define Data–related automated tests.
Add
DesignScriptBuiltin.dllandDSCoreNodes.dllto preload inDefineDataTests.Declarations
Check these if you believe they are true
Release Notes
Fixed a crash when running define Data–related automated tests.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of