Skip to content

Landunit *1d_ityp* variable long names are incorrect #4021

@samsrabin

Description

@samsrabin

Brief summary of bug

CTSM/src/main/histFileMod.F90

Lines 3883 to 3885 in e1f563b

call ncd_defvar(varname='land1d_ityplunit', xtype=ncd_int, dim1name=namel, &
long_name='landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)', &
ifill_value=ispval, ncid=ncid)

CTSM/src/main/histFileMod.F90

Lines 3913 to 3915 in e1f563b

call ncd_defvar(varname='cols1d_itype_lunit', xtype=ncd_int, dim1name=namec, &
long_name='column landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)', &
ifill_value=ispval, ncid=ncid)

CTSM/src/main/histFileMod.F90

Lines 3952 to 3954 in e1f563b

call ncd_defvar(varname='pfts1d_itype_lunit', xtype=ncd_int, dim1name=namep, &
long_name='pft landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)', &
ifill_value=ispval, ncid=ncid)

The values are listed as "vegetated,urban,lake,wetland,glacier or glacier_mec", but this is incorrect. Based on the global ltype_* attributes, it should be "vegetated/bare soil, crop, ocean, landice, deep lake, wetland, urban tbd, urban hd, or urban md."

Even better would be to not list these at all, instead referring the user to the global attributes.

General bug information

CTSM version you are using: ctsm5.4.038

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: n/a

Important output or errors that show the problem

From ncdump:

land1d_ityplunit:long_name = "landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)" ;
...
cols1d_itype_lunit:long_name = "column landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)" ;
...
pfts1d_itype_lunit:long_name = "pft landunit type (vegetated,urban,lake,wetland,glacier or glacier_mec)" ;

Metadata

Metadata

Assignees

No one assigned

    Labels

    b4bbit-for-bitnextthis should get some attention in the next week or two. Normally each Thursday SE meeting.size: smallusabilityImprove or clarify user-facing options

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions