From f1f42b87d5fabdb083bfc58ef4725d451f9b8725 Mon Sep 17 00:00:00 2001 From: Kirihasio <297547998+Kirihasio2@users.noreply.github.com> Date: Fri, 7 Aug 2026 22:25:39 -0500 Subject: [PATCH] docs: neutralise third-party addon references in two comments Both comments explain a technique that stands on its own, and cited other addons only as corroboration. Reworded to describe the technique directly: - UpdateKeybinds: routing keybinds through the button so the keypress reads the paged "action" attr - Skin_Guild: hooksecurefunc post-hooks being taint-safe by design Comments only, no behaviour change. Co-Authored-By: Claude Opus 5 --- EllesmereUIActionBars/EllesmereUIActionBars.lua | 4 ++-- .../EllesmereUIBlizzardSkin_WindowPacks.lua | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/EllesmereUIActionBars/EllesmereUIActionBars.lua b/EllesmereUIActionBars/EllesmereUIActionBars.lua index c05f6e88..76701788 100644 --- a/EllesmereUIActionBars/EllesmereUIActionBars.lua +++ b/EllesmereUIActionBars/EllesmereUIActionBars.lua @@ -11253,8 +11253,8 @@ local function UpdateKeybinds() -- keybind would fire the un-paged slot while the icon (our explicit -- "action" attr) repages. Route those bars' keybinds through the -- button (SetOverrideBindingClick) so the keypress reads our paged - -- "action" attr -- exactly what empower/flyout already do, and what - -- ElvUI/Bartender do for every button via LibActionButton. + -- "action" attr -- exactly what empower/flyout already do, and the + -- standard approach for any bar whose slots are addon-managed. -- -- Class-default form paging (Druid/Rogue) is NOT custom paging: it -- rides on bonusbar, a native engine concept that ACTIONBUTTONn diff --git a/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua b/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua index c2389c17..e836691d 100644 --- a/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua +++ b/EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua @@ -3276,7 +3276,7 @@ local function Skin_Guild() -- secure roster refresh that a protected guild action (SetNote / -- SetGuildRankOrder) triggers, tainting that action -> ADDON_ACTION_FORBIDDEN -- (root-caused by bisection; @Halt57/@woaw guild-note reports). hooksecurefunc - -- post-hooks are taint-safe by design -- the pattern ElvUI uses here. + -- post-hooks are taint-safe by design, which is the standard fix here. if ml and ml.RefreshListDisplay and not GetFFD(ml).colRefreshHooked then GetFFD(ml).colRefreshHooked = true hooksecurefunc(ml, "RefreshListDisplay", WSkin.Debounce(SkinRosterColumns))