Skip to content

Commit 36c2084

Browse files
committed
rpc_client: fix ACK counter start value
Start the ACK counter at 0, not negative. This prevents the possibility of too many buffers pending on the receiving device, which would cause buffers to drop and hence the upload to fail. This slightly reduces write throughput. Signed-off-by: Jordan Yates <jordan@embeint.com>
1 parent c9753f5 commit 36c2084

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/infuse_iot/rpc_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def _run_data_send_core(
127127
return self._finalise_command(recv, rsp_decoder)
128128

129129
# Send data payloads chunked as requested
130-
ack_cnt = -ack_period
130+
ack_cnt = 0
131131
offset = 0
132132
for chunk_id, chunk in enumerate(data):
133133
hdr = rpc.DataHeader(self._request_id, chunk_id if packet_idx else offset)

0 commit comments

Comments
 (0)