Bug: Copy seems to not do a deep copy?

[Newtbytes]

I have the following patch, which is applied to all entity loot tables (via the pattern "loot_table/entities/.*\\.json"):

[
    {
        "op": "test",
        "path": "/type",
        "value": "minecraft:entity"
    },
    {
        "op": "test",
        "path": "/pools/0/entries/0/name",
        "value": "minecraft:rotten_flesh"
    },
    {
        "op": "copy",
        "from": "/pools/0",
        "path": "/temporary_pool"
    },
    {
        "op": "add",
        "path": "/temporary_pool/entries/0/name",
        "value": "gcats:cloth"
    },
    {
        "op": "move",
        "from": "/temporary_pool",
        "path": "/pools/-"
    }
]

I expected it to add a new pool that's the same as the first pool but with minecraft:rotten_flesh replaced with gcats:cloth, leaving the first pool unaffected. However, it replaces name in the first pool as well. Here is the output of /patched dump file minecraft:loot_table/entities/zombie.json:

{
  "type": "minecraft:entity",
  "pools": [
    {
      "bonus_rolls": 0.0,
      "entries": [
        {
          "type": "minecraft:item",
          "functions": [
            {
              "add": false,
              "count": {
                "type": "minecraft:uniform",
                "max": 2.0,
                "min": 0.0
              },
              "function": "minecraft:set_count"
            },
            {
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "enchantment": "minecraft:looting",
              "function": "minecraft:enchanted_count_increase"
            }
          ],
          "name": "gcats:cloth"
        }
      ],
      "rolls": 1.0
    },
    {
      "bonus_rolls": 0.0,
      "entries": [
        {
          "type": "minecraft:item",
          "conditions": [
            {
              "condition": "minecraft:entity_properties",
              "entity": "this",
              "predicate": {
                "vehicle": {
                  "type": "minecraft:zombie_horse"
                }
              }
            }
          ],
          "functions": [
            {
              "add": false,
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "function": "minecraft:set_count"
            },
            {
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "enchantment": "minecraft:looting",
              "function": "minecraft:enchanted_count_increase"
            }
          ],
          "name": "minecraft:red_mushroom"
        }
      ],
      "rolls": 1.0
    },
    {
      "bonus_rolls": 0.0,
      "conditions": [
        {
          "condition": "minecraft:killed_by_player"
        },
        {
          "condition": "minecraft:random_chance_with_enchanted_bonus",
          "enchanted_chance": {
            "type": "minecraft:linear",
            "base": 0.035,
            "per_level_above_first": 0.01
          },
          "enchantment": "minecraft:looting",
          "unenchanted_chance": 0.025
        }
      ],
      "entries": [
        {
          "type": "minecraft:item",
          "name": "minecraft:iron_ingot"
        },
        {
          "type": "minecraft:item",
          "name": "minecraft:carrot"
        },
        {
          "type": "minecraft:item",
          "functions": [
            {
              "conditions": [
                {
                  "condition": "minecraft:any_of",
                  "terms": [
                    {
                      "condition": "minecraft:entity_properties",
                      "entity": "this",
                      "predicate": {
                        "flags": {
                          "is_on_fire": true
                        }
                      }
                    },
                    {
                      "condition": "minecraft:entity_properties",
                      "entity": "direct_attacker",
                      "predicate": {
                        "equipment": {
                          "mainhand": {
                            "predicates": {
                              "minecraft:enchantments": [
                                {
                                  "enchantments": "#minecraft:smelts_loot"
                                }
                              ]
                            }
                          }
                        }
                      }
                    }
                  ]
                }
              ],
              "function": "minecraft:furnace_smelt"
            }
          ],
          "name": "minecraft:potato"
        }
      ],
      "rolls": 1.0
    },
    {
      "bonus_rolls": 0.0,
      "conditions": [
        {
          "condition": "minecraft:killed_by_player"
        },
        {
          "condition": "minecraft:entity_properties",
          "entity": "this",
          "predicate": {
            "flags": {
              "is_baby": true
            },
            "vehicle": {
              "type": "minecraft:chicken"
            }
          }
        }
      ],
      "entries": [
        {
          "type": "minecraft:item",
          "name": "minecraft:music_disc_lava_chicken"
        }
      ],
      "rolls": 1.0
    },
    { // moved from /temporary_pool by srl_dp/GCATs-datapack.zip
      "bonus_rolls": 0.0,
      "entries": [
        {
          "type": "minecraft:item",
          "functions": [
            {
              "add": false,
              "count": {
                "type": "minecraft:uniform",
                "max": 2.0,
                "min": 0.0
              },
              "function": "minecraft:set_count"
            },
            {
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "enchantment": "minecraft:looting",
              "function": "minecraft:enchanted_count_increase"
            }
          ],
          "name": "gcats:cloth"
        }
      ],
      "rolls": 1.0
    }
  ],
  "random_sequence": "minecraft:entities/zombie"
}

[Newtbytes]

Same thing occurs when using replace instead of add

[Newtbytes]

Same problem when replacing the move op with:

    {
        "op": "copy",
        "from": "/temporary_pool",
        "path": "/pools/-"
    },
    {
        "op": "remove",
        "path": "/temporary_pool"
    }

[EnderTurret]

So this issue seems to stem from the library not actually copying the element. Unfortunately while I can fix this pretty easily it's likely not going to propagate into the mod until the other work in that library is done. (You may have noticed the other issues that have been sitting and rotting on this repository. Fortunately, I just need to add tests for the new features to finish those.)

In the near future I plan to finish the remaining things that need to be done in the library and then adjust Patched to use a multiversion environment so that simultaneously supporting eight different versions is easier. Then I can make a release that will include this fix.

In the meantime, is there any particular reason you need to copy the rotten flesh pool? Are there many other loot tables containing rotten flesh in that specific spot that you couldn't simply hard-code the pool?

[Newtbytes]

Preferably I'd not hardcode the index of the pool, but I couldn't figure out how to use find to find a pool that contains an entry for rotten_flesh, then create a copy of that pool and add it to the pools while changing rotten_flesh to cloth

[EnderTurret]

Do you need to create a new pool at all? Could you just change the rotten flesh entry to a different entry type and have it drop either cloth or rotten flesh (or whatever your requirements are)?

Otherwise, if you absolutely must have this additional pool and you don't want to hard-code it per-loot-table then I think you'll have to wait for a version of Patched that fixes the copying. (You can't use find here because absolute paths haven't been introduced in the mod yet, so you wouldn't be able to copy the pool into the pools list. Besides, you'd run into the same copying problem.)

[Newtbytes]

I suppose that it would be better for gameplay reasons to add cloth to the same pool as rotten flesh anyways. Nevertheless I still think I'll have the same issues with copying and using find, since I want the cloth entry to inherit the same functions/properties as the rotten flesh entry. I really don't like the idea of hardcoding the entry because preferably I want this patch to be as blind to the specifics of the loot table being patched as possible.

Also, because multiversion mods have kind of itched my curiosity recently, would you accept contributions on that front (using stonecutter or whatever tool you prefer)?

[Newtbytes]

Aaaaand that was a misclick, I did not mean to close this issue and don't have permissions to reopen it. My bad, could you reopen this issue @EnderTurret?

[EnderTurret]

Also, because multiversion mods have kind of itched my curiosity recently, would you accept contributions on that front (using stonecutter or whatever tool you prefer)?

Likely not, mostly just because my style of "multiversion" differs from what most people would do. (I'm not sure anyone is doing exactly what I am.) It's closer to 'what if multi-platform mods had even more subprojects'. I'm sure it sounds terrible to stonecutter people, but I really dislike the preprocessor comments. (I also think Patched would benefit less from the comments when it really just needs a bigger Platform interface.) Besides, I require whatever solution I use to work with Eclipse — an IDE evidently much of the software development world would like to pretend vanished the moment IDEA came into existence.

(If you were curious, last December I got sucked into the concept of multiversion mods, proceeded to convert seven mods, and now I have most of them simultaneously supporting 1.7.10 ~ 1.21.11. It's great for mods that don't need to change much — like Patched. For Patched, I'll probably only be going as far back as 1.18.2, if I feel like going even that far. I'm not really sure how popular 1.19.2 and below are these days.)

[EnderTurret]

This has been fixed in version 9.0.0.