refactor: fix linter errors

Author: Makcal

.clang-tidy

@@ -31,8 +31,7 @@ Checks: "*,
         -bugprone-easily-swappable-parameters,
         -misc-non-private-member-variables-in-classes,
         -llvm-header-guard,
-
-        -misc-include-cleaner"
+        "
 CheckOptions:
   cppcoreguidelines-pro-type-member-init.IgnoreArrays: true
   readability-implicit-bool-conversion.AllowPointerConditions: true

src/handlers/cooking_planning/view.cpp

@@ -72,7 +72,7 @@ void handleCookingPlanningCQ(
             state.availability |
             transform([](const auto& ia) { return SelectableIngredient{{ia.ingredient.id, ia.ingredient.name}}; }) |
             to<std::vector>();
-        std::optional<api::StorageId> theOnlyStorage = getTheOnlyStorage(state);
+        const std::optional<api::StorageId> theOnlyStorage = getTheOnlyStorage(state);
         renderIngredientsSpending(ingredients, theOnlyStorage.has_value(), userId, chatId, bot);
         CookingIngredientsSpending newState{
             .prevState = std::move(state), .storageId = theOnlyStorage, .ingredients = std::move(ingredients)};

src/handlers/recipes_suggestions/view.cpp

@@ -8,26 +8,26 @@
 #include "render/main_menu/view.hpp"
 #include "render/recipes_suggestions/view.hpp"
 #include "render/storage/view.hpp"
-#include "render/storages_selection/view.hpp"
 #include "utils/ingredients_availability.hpp"
 #include "utils/parsing.hpp"
 
 #include <optional>
 #include <stdexcept>
 #include <string>
+#include <string_view>
 #include <utility>
 #include <variant>
 #include <vector>
 
 namespace cookcookhnya::handlers::recipes_suggestions {
 
 using namespace render::recipes_suggestions;
-using namespace render::select_storages;
 using namespace render::storage;
 using namespace render::cooking_planning;
 using namespace render::main_menu;
 using namespace api::models::storage;
 using namespace std::views;
+using namespace std::literals;
 
 void handleSuggestedRecipesListCQ(
     SuggestedRecipesList& state, CallbackQueryRef cq, BotRef bot, SMRef stateManager, api::ApiClientRef api) {
@@ -56,16 +56,18 @@ void handleSuggestedRecipesListCQ(
     }
 
     if (data.starts_with("recipe_")) {
-        auto recipeId = utils::parseSafe<api::RecipeId>(data.substr(sizeof("recipe_") - 1));
+        auto recipeId = utils::parseSafe<api::RecipeId>(std::string_view{data}.substr("recipe_"sv.size()));
         if (!recipeId)
             return;
 
         std::vector<CookingPlanning::IngredientAvailability> inStorage =
             utils::inStoragesAvailability(state.getStorageIds(), *recipeId, userId, api);
 
         renderCookingPlanning(inStorage, *recipeId, userId, chatId, bot, api);
-        stateManager.put(CookingPlanning{
-            .prevState = std::move(state), .addedStorages = {}, .availability = inStorage, .recipeId = *recipeId});
+        stateManager.put(CookingPlanning{.prevState = std::move(state),
+                                         .addedStorages = {},
+                                         .availability = std::move(inStorage),
+                                         .recipeId = *recipeId});
         return;
     }