RFE: Re-enable Admin Panel

[adriangibanelbtactic]

Admin Panel was supposed to be an Enterprise-Edition only feature but it went turned on as a regular feature.

OnlyOffice reinstanted their intended behaviour in: ONLYOFFICE/document-server-package@036f320 by forcing it to be only be built in the either documentserver-de or documentserver-ee but not in regular documentserver.

So... Admin Panel should be reinstated by reverting this commit. Or probably a better approach that involves less maintenance is adding a new commit that removes those checks so that it always defines the Admin Panel service and configuration to LINUX_DEPS and COMMON_DEPS.

Second related commit: ONLYOFFICE/document-server-package@267ecf1 specific to Windows

[juliusknorr]

Makes sense, would you be up for opening a pull request with the change directly?

[adriangibanelbtactic]

Makes sense, would you be up for opening a pull request with the change directly?

Yes, no problem.

I would need some guidance on how the actual implementation is done regarding making proper commits (nice) or making commits that are easier to maintain from a fork point of view (not so nice).

The current status of the Admin Panel re-enablement (in OnlyOffice itself) is that it does not seem to work so it might need some more work on my side. It might be related to the fact that it's the first time I try to build an OnlyOffice 9.4.x version and they have might changed something in the build system again.

You can take a look at the latest branch where I re-integrated Admin Panel. It features commits that are easier to maintain from a fork point of view.

[juliusknorr]

They have dropped the code for the admin panel in the repositories and also rewritten git history to remove the occurrences. I think you could just propose those commits you already have to this repo.

[adriangibanelbtactic]

They have dropped the code for the admin panel in the repositories and also rewritten git history to remove the occurrences.

Are you sure they have actually removed the code in the repositories?

I believe you might have found divergent branches and you might have concluded that OnlyOffice rewrote its git history.
I already found that myself but I concluded they did not actually rewrote the git history but just published and alternate git history which did not have signed commit... but the same changes.

I copy-and-paste additional details I wrote down back in the day:

---

OnlyOffice has suddenly pushed-forced old tags for the sake of it. So, we now have:

• https://github.com/ONLYOFFICE/server/releases/tag/v99.99.99.2471
  • Author: konovalovsergey
  • Date: Tagged this Jun 7, 2021
  • Description: v99.99.99.2471: Merge pull request #275 from ONLYOFFICE/release/v6.4.0
  • Associated commit: 8915d819221782c4223a5885051ea007e5cbadbc
• https://github.com/btactic-oo-old-verified/server/releases/tag/v99.99.99.2471
  • Author: konovalovsergey
  • Date: Tagged this Jun 7, 2021
  • Description: v99.99.99.2471: Merge pull request #275 from ONLYOFFICE/release/v6.4.0
  • Associated commit: b746ad8221088f47fdbbeca76dd6c76d1cc60e43

Similar thing happened to: v6.4.0.33 and many more tags. In both onlyoffice and btactic 'server' repos there are 1749 commits. We are not sure any more if they represent the same changes.

After some more digging: common commit in history is:

• btactic-oo-old-verified/server@51b574e
• ONLYOFFICE/server@51b574e

Then it diverges:

• btactic-oo-old-verified/server@47393e9
• ONLYOFFICE/server@5389d02

The btactic-oo-old-verified (original one) is verified. Clicking on Verified we can see:

This commit was signed with the committer's verified signature.
ShockwaveNN
GPG Key ID: 8DAD236C00523ECF
Verified on Nov 13, 2024, 12:27 AM

The other one, despite being exactly the same set of changes and author is not verified.

So... it's like some obscure repo (inside of Ascensio dev machines) which did not have commits with their verified signatures has been pushed-forced and that's there's a divergence.

Github UI comparison:

https://github.com/btactic-oo-old-verified/server/commits/v6.1.0.1/?after=c274cb2739dfc439811fe48a33a3554888aa046f+565
https://github.com/ONLYOFFICE/server/commits/v6.1.0.1/?after=9d8bdfaa645517c5df6abcf0b45c06ad30870a62+565

[juliusknorr]

Ah the tags maybe not but the branches had been rewritten 👍

[rikled]

Just noticed this issue. I removed the checks here (for linux):
#8