Skip to content

Commit 34c7605

Browse files
committed
Merge branch 'SIG-5340-v5'
* SIG-5340-v5: (22 commits) Refactor ensure successful status code Add integration test for complex file metadata Refactor various style improvements Fix simplify null checks Refactor to request objects for transaction creation Remove obsolete methods Refactor test ResponseBody in exceptions Refactor use BadAuthorizationException Remove unused activity types Add converter for Field value Add FileFieldType enum Refactor EnsureAvailableStatusCode to be async Refactor to nullable enable Make remove documentation warnings Remove support weak digest hash algos Reformat use file-scoped namespaces Remove obsolete exception Fix or suppress StyleCop Analyzer warnings Remove unused using directives Remove NCrunch ... Fixes SIG-5340
2 parents 48c78b7 + 42fa266 commit 34c7605

125 files changed

Lines changed: 3985 additions & 4413 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.editorconfig

Lines changed: 43 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,50 @@ root = true
33
[*]
44
charset = utf-8
55
indent_style = tab
6+
insert_final_newline = true
67

7-
[*.{cs,js}]
8+
[*.{cs,cshtml,js}]
89
trim_trailing_whitespace = true
910
insert_final_newline = true
1011

11-
[*.csproj]
12-
indent_style = space
12+
dotnet_sort_system_directives_first = true : warning
13+
dotnet_style_predefined_type_for_locals_parameters_members = true : warning
14+
dotnet_style_object_initializer = true : warning
15+
dotnet_style_collection_initializer = true : warning
16+
dotnet_style_explicit_tuple_names = true : error
17+
dotnet_style_coalesce_expression = true : warning
18+
dotnet_style_null_propagation = true : warning
19+
20+
# Prefer "var" everywhere
21+
csharp_style_var_for_built_in_types = false : suggestion
22+
csharp_style_var_when_type_is_apparent = true : suggestion
23+
csharp_style_var_elsewhere = false : none
24+
25+
# Prefer method-like constructs to have a block body
26+
csharp_style_expression_bodied_methods = false : none
27+
csharp_style_expression_bodied_constructors = false : none
28+
csharp_style_expression_bodied_operators = false : none
29+
30+
# Prefer property-like constructs to have an expression-body
31+
csharp_style_expression_bodied_properties = true : none
32+
csharp_style_expression_bodied_indexers = true : none
33+
csharp_style_expression_bodied_accessors = true : none
34+
35+
# Suggest more modern language features when available
36+
csharp_style_pattern_matching_over_is_with_cast_check = true : suggestion
37+
csharp_style_pattern_matching_over_as_with_null_check = true : suggestion
38+
csharp_style_inlined_variable_declaration = true : suggestion
39+
csharp_style_throw_expression = true : suggestion
40+
csharp_style_conditional_delegate_call = true : suggestion
41+
42+
# Newline settings
43+
csharp_new_line_before_open_brace = types, methods, properties, indexers, events, event_accessors, anonymous_types, object_collections, array_initializers, local_functions
44+
csharp_new_line_before_else = true
45+
csharp_new_line_before_catch = true
46+
csharp_new_line_before_finally = true
47+
csharp_new_line_before_members_in_object_initializers = true
48+
csharp_new_line_before_members_in_anonymous_types = true
49+
50+
[*.{props,targets,config,nuspec,csproj}]
51+
indent_style = tab
52+
indent_size = 2

.gitattributes

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
*.edmx text
1717
*.resx text
1818

19-
*.ncrunchproject text
20-
*.ncrunchsolution text
21-
2219
# Custom for Visual Studio
2320
*.sln text eol=crlf merge=union
2421
*.csproj text

.github/workflows/publish_nuget_package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Setup .NET
1616
uses: actions/setup-dotnet@v5
1717
with:
18-
dotnet-version: '8.x'
18+
dotnet-version: '10.x'
1919

2020
- name: Check for Tag on Current Commit
2121
run: |

.gitignore

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,6 @@ _TeamCity*
104104
# DotCover is a Code Coverage Tool
105105
*.dotCover
106106

107-
# NCrunch
108-
_NCrunch_*
109-
.*crunch*.local.xml
110-
*.v3.ncrunchsolution.user
111-
112107
# MightyMoose
113108
*.mm.*
114109
AutoTest.Net/

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ For full API documentation, please visit [evidos.github.io](https://evidos.githu
1515
### Example code
1616
The following code is an example of how to create and start a sign transaction with two documents.
1717
```c#
18-
var settings = new SignHostApiClientSettings(
18+
var settings = new SignhostApiClientSettings(
1919
"AppName appkey",
20-
"apikey or usertoken"));
20+
"apikey or usertoken");
2121

22-
var client = new SignHostApiClient(settings);
22+
var client = new SignhostApiClient(settings);
2323

24-
var transaction = await client.CreateTransactionAsync(new Transaction {
25-
Signers = new List<Signer> {
26-
new Signer {
24+
var transaction = await client.CreateTransactionAsync(new CreateTransactionRequest {
25+
Signers = new List<CreateSignerRequest> {
26+
new CreateSignerRequest {
2727
Email = "john.doe@example.com",
2828
SignRequestMessage = "Could you please sign this document?",
2929
SendSignRequest = true,

src/SignhostAPIClient.IntegrationTests/SignhostAPIClient.IntegrationTests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup Label="Build">
3-
<TargetFrameworks>net8.0</TargetFrameworks>
3+
<TargetFrameworks>net10.0</TargetFrameworks>
44
<IsPackable>false</IsPackable>
55
<IsTestProject>true</IsTestProject>
66
<CodeAnalysisRuleSet>../signhost.ruleset</CodeAnalysisRuleSet>
@@ -12,7 +12,6 @@
1212
</ItemGroup>
1313

1414
<ItemGroup Label="Package References">
15-
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
1615
<PackageReference Include="FluentAssertions" Version="7.2.0" />
1716
<PackageReference Include="xunit" Version="2.9.3" />
1817
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />

0 commit comments

Comments
 (0)