-
Notifications
You must be signed in to change notification settings - Fork 0
Constrain CurseForge test result publishing to the exact repository and commit #33
Copy link
Copy link
Open
Labels
P2High: major functionality is broken or crashes with limited workaroundHigh: major functionality is broken or crashes with limited workaroundarea:testingAutomated tests, fixtures, and validation infrastructureAutomated tests, fixtures, and validation infrastructureloader:commonShared Common implementation or assetsShared Common implementation or assetsstatus:backlogValid work that is not currently scheduledValid work that is not currently scheduledtype:bugA defect or incorrect behaviorA defect or incorrect behavior
Description
Metadata
Metadata
Assignees
Labels
P2High: major functionality is broken or crashes with limited workaroundHigh: major functionality is broken or crashes with limited workaroundarea:testingAutomated tests, fixtures, and validation infrastructureAutomated tests, fixtures, and validation infrastructureloader:commonShared Common implementation or assetsShared Common implementation or assetsstatus:backlogValid work that is not currently scheduledValid work that is not currently scheduledtype:bugA defect or incorrect behaviorA defect or incorrect behavior
Summary
When local PR lookup fails, curseforge_testing.py performs a global GitHub search by branch name and mutates the first matching pull request without requiring the expected repository or head commit.
Evidence
Impact
A common branch name can cause private local test details and labels to be posted to an unrelated repository where the authenticated user has write access.
Reproduction / verification
Proposed direction
Remove the unrestricted global fallback. Require an explicit owner/repository allowlist and exact head SHA agreement before any GitHub mutation.
Acceptance criteria
Audit provenance
Candidate #6 from the read-only repository audit performed on 2026-07-20. This is separate from existing issues #3, #4, #25, and #27 unless explicitly linked later.