Skip to content

Make pull-request build checks compile the actual feature branch #39

Description

@Exohayvan

Summary

The Build Current Branch workflow reports success for feature branches whose names do not begin with minecraft/ or stardewvalley/, while both real build steps are skipped.

Evidence

Impact

Pull requests can satisfy a green build check without compiling any source, allowing incompatible or uncompilable changes to appear validated.

Reproduction / verification

  • Push a harmless compile failure to a representative feature branch in a test context.
  • Verify the required PR check fails because the relevant loader target is compiled.

Proposed direction

Use pull_request metadata and base branch/target mapping rather than relying on the feature branch prefix. Fail the job when no target build is selected.

Acceptance criteria

  • Every loader and Stardew PR compiles the intended target checkout.
  • A job with no selected target fails instead of succeeding as a no-op.
  • Checks use the tested PR SHA and expose the selected target in logs.
  • Workflow tests cover slash and hyphen feature-branch names.

Audit provenance

Candidate #13 from the read-only repository audit performed on 2026-07-20. This is separate from existing issues #3, #4, #25, and #27 unless explicitly linked later.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Medium: normal functional defect or important work with a workaroundarea:testingAutomated tests, fixtures, and validation infrastructureloader:commonShared Common implementation or assetsstatus:backlogValid work that is not currently scheduledtype:bugA defect or incorrect behavior

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions