Confidence: high · Effort: small (<1 d)
Problem
The DMR de-interleave tables rW, rX, rY, rZ, sf_dibit_idx (originally from DSD-FME's dmr_const.h) are duplicated across three files. Any future correction to these constants has to be applied in four places (the .cu file also has a host/device pair).
Files: src/bruteforce.cu:366-418 (device + host copies), src/bruteforce.c:137-162, src/test_strict_score.c:47-78
Suggested fix
Put a single canonical copy in include/dmr_const.h as static const. The .cu file can wrap it once into __constant__ initializers in the launcher.
Why it matters
Eliminates a "fixed in one place, not the others" bug class. Good groundwork for the upcoming CLI build using bruteforce.c as a base.
Confidence: high · Effort: small (<1 d)
Problem
The DMR de-interleave tables
rW,rX,rY,rZ,sf_dibit_idx(originally from DSD-FME'sdmr_const.h) are duplicated across three files. Any future correction to these constants has to be applied in four places (the .cu file also has a host/device pair).Files:
src/bruteforce.cu:366-418(device + host copies),src/bruteforce.c:137-162,src/test_strict_score.c:47-78Suggested fix
Put a single canonical copy in
include/dmr_const.hasstatic const. The.cufile can wrap it once into__constant__initializers in the launcher.Why it matters
Eliminates a "fixed in one place, not the others" bug class. Good groundwork for the upcoming CLI build using
bruteforce.cas a base.