Deserialization of heterogeneous list

[kristofvb]

Hi,

I have some questions about the following sample:

class ParseTest {

    @Test
    void parse() throws Exception {
        var mapper = new XmlMapper();
        var root = mapper.readValue("""
                <root>
                    <foos>
                        <foo sequenceNr="1">somefoo</foo>
                        <foo sequenceNr="2">otherfoo</foo>
                        <bar>something very different</bar>
                    </foos>
                </root>
                """, Root.class);
        System.out.println(root);
    }

    private static class Root {
        @JacksonXmlProperty(localName = "foos")
        private List<Foo> foos = new ArrayList<>();

        public String toString() {
            return "Root{" +
                    "foos=" + foos +
                    '}';
        }
    }

    private static class Foo {
        @JacksonXmlText
        String text;

        @JacksonXmlProperty(isAttribute = true)
        Integer sequenceNr;

        public String toString() {
            return "Foo{" +
                    "text='" + text + '\'' +
                    ", sequenceNr=" + sequenceNr +
                    '}';
        }
    }

}

• is there a way to make sure the foos list only contains Foo instances for actual foo elements and avoid turning the bar element into a Foo instance?
• is there a way (annotation) to sort the foos list on sequenceNr of the elements? Currently I sort the list in the foos setter (which I omitted in the sample).

Thanks for looking into this.

[cowtowncoder]

1. "is there a way to make sure the foos list only contains Foo instances for actual foo elements and avoid turning the bar element into a Foo instance?"

I think that should be caught, yes, by name not matching. If they do get converted, a failing test would be good.

2. "is there a way (annotation) to sort the foos list on sequenceNr of the elements? ?"

No, there is no declarative way to do that in Jackson.

[kristofvb]

This test fails

class ParseTest {

    @Test
    void parse() throws Exception {
        var mapper = new XmlMapper();
        var root = mapper.readValue("""
                <root>
                    <foos>
                        <foo sequenceNr="1">somefoo</foo>
                        <foo sequenceNr="2">otherfoo</foo>
                        <bar>something very different</bar>
                    </foos>
                </root>
                """, Root.class);
        assertEquals(List.of(new Foo("somefoo", 1), new Foo("otherfoo", 2)), root.foos);
    }

    static class Root {
        @JacksonXmlProperty
        List<Foo> foos = new ArrayList<>();
    }

    static class Foo {
        @JacksonXmlText
        String text;
        @JacksonXmlProperty(isAttribute = true)
        Integer sequenceNr;

        public Foo() {
        }

        public Foo(String text, Integer sequenceNr) {
            this.text = text;
            this.sequenceNr = sequenceNr;
        }

        @Override
        public String toString() {
            return "Foo{" +
                    "text='" + text + '\'' +
                    ", sequenceNr=" + sequenceNr +
                    '}';
        }
    }

}

[cowtowncoder]

Thank you @kristofvb -- sounds like a possible bug then, depending on exactly how things fail (creating 3rd item would be wrong; should either ignore or fail, depending on setting (DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)).

I created issue #787 to track .

[cowtowncoder]

Closing to avoid duplication with #787.